GET /xrpc/tech.waow.typeahead.searchActors typeahead.waow.tech

Use Zat's strict percent decoder for profile blob CIDs #51

Open zzstoatzz.io
Open opened by zzstoatzz.io

At current default-branch commit 5753f7ac9c46ee82ad89ca588f11206a51393ef4, percentDecoded in services/src/store_process/profile.zig:89 parses each percent pair with std.fmt.parseInt(u8, pair, 16).

That accepts signs: a getBlob URL with cid=%+A yields newline and cid=%-0 yields NUL, rather than the empty result used for invalid escapes. This contradicts the helper's intended decodeURIComponent behavior. No downstream exploit is claimed.

Adopt zat.percent.decodeAlloc from Zat v0.7.0-alpha.10 or newer, preserving Typeahead's existing contract:

  • Keep the no-percent borrowing fast path.
  • Map InvalidPercentEncoding to an empty result and propagate allocation failure.
  • Retain utf8ValidateSlice; the shared decoder intentionally returns raw bytes.
  • Preserve literal + and exactly one decoding pass.

Add regression coverage through blobCid for query and CDN path inputs, signed/truncated/nonhex escapes, invalid UTF-8, %2B, %2523, and allocation failure. Run adversarial review, replayable fuzz/property checks and focused profile-decoding performance measurements before shipping.

The separate tolerant HTTP query decoder is not a drop-in strict replacement and is outside this issue. Background: Zat/ZDS shared-decoder review, following Brooke's ZDS contribution.

Related: Zat form-decoding ownership/API follow-up.

Sign up or Sign in to add to the discussion.