fix: following feed always shown at the start #1

merged opened by

koi.rip 1 week ago targeting main from koi.rip/bbell: push-qzwmowktkklw

meow mewo meow !

my following feed is like NOT first AT ALL and thi s showd it first bcoz it was being added to pinnedItems in the first loop while everything else was in the second one !

also mayb tink about refactoring dis code abit cause a theres loooot of iterations over the same tings !

tank you :3

waw was lot of typing my paws tired now :c

Labels

None yet.

assignee

None yet.

Participants 2

AT URI

at://did:plc:b26ewgkrnx3yvsp2cdao3ntu/sh.tangled.repo.pull/3mi22o3ftnt22

+8 -11

1 changed file

Diff round #0

expand all

src

views

Root

HomeView.vue

+8 -11

src/views/Root/HomeView.vue

··· 57 57 const pinnedItems: PinnedFeedItem[] = [] 58 58 59 59 for (const item of savedFeedsPref.items) { 60 - if (item.type === 'timeline') { 61 - pinnedItems.push({ 62 - type: 'timeline', 63 - displayName: 'Following', 64 - }) 65 - } else if (item.type === 'feed') { 66 - feedUris.push(item.value as ResourceUri) 67 - } else if (item.type === 'list') { 68 - listUris.push(item.value as ResourceUri) 69 - } 60 + if (item.type === 'feed') feedUris.push(item.value as ResourceUri) 61 + else if (item.type === 'list') listUris.push(item.value as ResourceUri) 70 62 } 71 63 72 64 let feedGenerators: AppBskyFeedDefs.GeneratorView[] = [] ··· 89 81 } 90 82 91 83 for (const item of savedFeedsPref.items) { 92 - if (item.type === 'feed') { 84 + if (item.type === 'timeline') { 85 + pinnedItems.push({ 86 + type: 'timeline', 87 + displayName: 'Following', 88 + }) 89 + } else if (item.type === 'feed') { 93 90 const generator = feedGenerators.find((g) => g.uri === item.value) 94 91 if (generator) { 95 92 pinnedItems.push({

History

1 round 2 comments

koi.rip submitted #0 11d

1 commit

expand

868fda20

fix: following feed always shown at the start

expand 2 comments

vt3e.cat 11d

ohg yay thabk u

koi.rip 11d

omg wow no pobel !

pull request successfully merged