import AppKit import Foundation import ParcelConfig import ParcelTestSupport import ParcelUI import Testing @testable import ParcelUpdate @MainActor private final class ReadyUpdateDriver: UpdateDriver { var canCheckForUpdates = true var availableVersion: String? { didSet { availabilityDidChange?() } } var isReadyToRestart = false { didSet { availabilityDidChange?() } } var availabilityDidChange: (@MainActor () -> Void)? var installations = 0 func start() throws {} func checkForUpdates() {} func restartToUpdate() -> Bool { guard isReadyToRestart else { return false } installations += 1 return true } } extension AppKitTestSuite { @MainActor struct UpdateMenuIntegrationTests { @Test func moreKeepsThreeActionsAndUpdateDotsThroughDiscoveryAndReconciliation() throws { _ = NSApplication.shared let driver = ReadyUpdateDriver() let updater = UpdateController(isEnabled: true) { driver } let controller = try MenuBarController { _ in } defer { controller.stop() } controller.onKeyboardShortcutsRequested = {} controller.onSupportRequested = { _ in } controller.onMenuRendered = { menu in let more = menu.items.first { $0.title == "More" }?.submenu guard let more else { Issue.record("More must be present"); return } updater.installMenuItem(in: more, at: 1) } try updater.start() for (index, ready) in [false, true, true, false].enumerated() { driver.availableVersion = ready ? "2.4" : nil driver.isReadyToRestart = ready && index == 2 controller.update( snapshot: .preview, configuration: .defaults, permission: .granted, reduceMotion: true, increaseContrast: index == 2, updateReady: driver.isReadyToRestart, updateVersion: driver.availableVersion, showUpdateCard: false) controller.menuNeedsUpdate(controller.menu) let parent = try #require(controller.menu.items.first { $0.title == "More" }) let more = try #require(parent.submenu) #expect(more.items.map(\.title) == ["Keyboard Shortcuts…", "Check for Updates…", "Send Feedback…"]) let check = more.items[1] #expect((check.image != nil) == ready) #expect((parent.image != nil) == ready) #expect(parent.accessibilityLabel() == (ready ? "More, update ready" : "More")) #expect(check.accessibilityLabel() == (ready ? "Check for Updates…, update ready" : check.title)) #expect(check.isEnabled) #expect(!controller.menu.items.contains { $0.title == "Check for Updates…" }) controller.menuNeedsUpdate(controller.menu) #expect(more.items.count == 3) } driver.isReadyToRestart = true let parent = try #require(controller.menu.items.first { $0.title == "More" }) #expect(updater.availableVersion == nil) #expect(parent.image != nil) #expect(parent.accessibilityLabel() == "More, update ready") #expect(parent.submenu?.items[1].image != nil) } @Test func fakeDriverUpdatesTheShellWithoutNetwork() async throws { _ = NSApplication.shared let directory = FileManager.default.temporaryDirectory.appendingPathComponent(UUID().uuidString) try FileManager.default.createDirectory(at: directory, withIntermediateDirectories: false) defer { do { try FileManager.default.removeItem(at: directory) } catch { Issue.record(error) } } let suite = "ParcelUpdateTests.\(UUID().uuidString)" let defaults = try #require(UserDefaults(suiteName: suite)) defaults.set(true, forKey: "guidedTour.v2.completed") defer { defaults.removePersistentDomain(forName: suite) } let config = directory.appendingPathComponent("parcel.toml") try "[motion]\nenabled = false\n".write(to: config, atomically: true, encoding: .utf8) let services = PreviewShellServices(permission: .granted) let shell = ParcelShell( layouts: services, permissions: services, commands: services, configStore: ConfigStore(fileURL: config), defaults: defaults, preview: true) let driver = ReadyUpdateDriver() let updater = UpdateController(isEnabled: true) { driver } updater.availabilityDidChange = { [weak shell, weak updater] in guard let shell, let updater else { return } shell.showUpdate(ready: updater.isReadyToRestart, version: updater.availableVersion, showCard: true) } shell.onInstallUpdate = { [weak updater] in _ = updater?.restartToUpdate() } shell.onDeferUpdate = { [weak shell, weak updater] in guard let updater else { return } shell?.showUpdate(ready: updater.isReadyToRestart, version: updater.availableVersion, showCard: false) } do { try await shell.start() let deadline = ContinuousClock.now.advanced(by: .seconds(2)) while shell.menuBar?.statusItem.button?.accessibilityValue() as? String != "Tiling 3 windows · Side", ContinuousClock.now < deadline { try await Task.sleep(for: .milliseconds(10)) } try updater.start() let controller = try #require(shell.menuBar) driver.availableVersion = "2.4" #expect(controller.statusItem.button?.accessibilityLabel() == "Parcel") driver.isReadyToRestart = true #expect(controller.statusItem.button?.accessibilityLabel() == "Parcel, update ready") controller.menuNeedsUpdate(controller.menu) let item = try #require(controller.menu.items.first { $0.identifier?.rawValue == "menu.problem" }) #expect(item.title == "Update 2.4 ready") let actions = try #require(item.submenu) actions.performActionForItem(at: 0) #expect(driver.installations == 1) actions.performActionForItem(at: 1) #expect(updater.isReadyToRestart) controller.menuNeedsUpdate(controller.menu) #expect(!controller.menu.items.contains { $0.identifier?.rawValue == "menu.problem" }) driver.isReadyToRestart = false #expect(controller.statusItem.button?.accessibilityLabel() == "Parcel") await shell.stop() } catch { await shell.stop() throw error } } @Test func shellShowsOnlyTheReadyUpdateProblemAndRoutesItsAction() async throws { _ = NSApplication.shared let directory = FileManager.default.temporaryDirectory.appendingPathComponent(UUID().uuidString) try FileManager.default.createDirectory(at: directory, withIntermediateDirectories: false) defer { do { try FileManager.default.removeItem(at: directory) } catch { Issue.record(error) } } let suite = "ParcelUpdateTests.\(UUID().uuidString)" let defaults = try #require(UserDefaults(suiteName: suite)) defaults.set(true, forKey: "guidedTour.v2.completed") defer { defaults.removePersistentDomain(forName: suite) } let config = directory.appendingPathComponent("parcel.toml") try "[motion]\nenabled = false\n".write(to: config, atomically: true, encoding: .utf8) let services = PreviewShellServices(permission: .granted) let shell = ParcelShell( layouts: services, permissions: services, commands: services, configStore: ConfigStore(fileURL: config), defaults: defaults) var requested: [MenuProblem] = [] shell.onProblemRequested = { requested.append($0) } do { try await shell.start() let deadline = ContinuousClock.now.advanced(by: .seconds(2)) while shell.menuBar?.statusItem.button?.accessibilityValue() as? String != "Tiling 3 windows · Side", ContinuousClock.now < deadline { try await Task.sleep(for: .milliseconds(10)) } let controller = try #require(shell.menuBar) shell.showProblem(.updateReady) controller.menuNeedsUpdate(controller.menu) let item = try #require(controller.menu.items.first { $0.identifier?.rawValue == "menu.problem" }) #expect(item.title == "Update ready — Restart to update") #expect(!controller.menu.items.contains { $0.title == "Check for Updates…" }) controller.menu.performActionForItem(at: controller.menu.index(of: item)) #expect(requested == [.updateReady]) shell.showProblem(nil) controller.menuNeedsUpdate(controller.menu) #expect(!controller.menu.items.contains { $0.identifier?.rawValue == "menu.problem" }) await shell.stop() } catch { await shell.stop() throw error } } } }