tjh.dev
1From d025d0eeae1c5266063bdc1476dbdff121bcfa57 Mon Sep 17 00:00:00 2001
2From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com>
3Date: Wed, 31 Jan 2024 17:44:59 +0100
4Subject: [PATCH] Fix building with GCC 14
5
6GCC 14 becomes stricter regarging pointer types:
7
8goocanvasitemsimple.c: In function 'goo_canvas_item_simple_set_model':
9goocanvasitemsimple.c:1539:15: error: assignment to 'GooCanvasItemModelSimple *' {aka 'struct _GooCanvasItemModelSimple *'} from incompatible pointer type 'GooCanvasItemModel *' {aka 'struct _GooCanvasItemModel *'} [-Wincompatible-pointer-types]
10 1539 | item->model = g_object_ref (model);
11 | ^
12make[3]: *** [Makefile:595: goocanvasitemsimple.lo] Error 1
13
14It looks like missing a pointer cast.
15
16<https://bugzilla.redhat.com/show_bug.cgi?id=2261209>
17---
18 src/goocanvasitemsimple.c | 2 +-
19 1 file changed, 1 insertion(+), 1 deletion(-)
20
21diff --git a/src/goocanvasitemsimple.c b/src/goocanvasitemsimple.c
22index 19b3424..28edc77 100644
23--- a/src/goocanvasitemsimple.c
24+++ b/src/goocanvasitemsimple.c
25@@ -1536,7 +1536,7 @@ goo_canvas_item_simple_set_model (GooCanvasItemSimple *item,
26 goo_canvas_item_simple_free_data (item->simple_data);
27 g_slice_free (GooCanvasItemSimpleData, item->simple_data);
28
29- item->model = g_object_ref (model);
30+ item->model = (GooCanvasItemModelSimple *) g_object_ref (model);
31 item->simple_data = &item->model->simple_data;
32
33 if (accessibility_enabled)
34--
35GitLab
36