pkgs/applications/emulators/zsnes/fortify3.patch at devShellTools-shell · tjh.dev/nixpkgs

tjh.dev / nixpkgs

Clone of https://github.com/NixOS/nixpkgs.git (to stress-test knotserver)

nixpkgs / pkgs / applications / emulators / zsnes / fortify3.patch

at devShellTools-shell 20 lines 749 B view raw

 1pal16bxcl is an array of 256 dwords, not bytes:
 2    src/endmem.asm:NEWSYM pal16bxcl, resd 256
 3
 4While at it fixes off-by-4 out of bounds exit.
 5
 6Detected by _FORTIFY_SOURCE=3:
 7    *** buffer overflow detected ***: terminated
 8    #7  0x08057c14 in memset (__len=2, __ch=255, __dest=<optimized out>) at ...-glibc-2.38-23-dev/include/bits/string_fortified.h:59
 9#8  clearmem () at initc.c:1461
10--- a/src/initc.c
11+++ b/src/initc.c
12@@ -1389,7 +1389,7 @@ extern unsigned char vidmemch8[4096];
13 extern unsigned char pal16b[1024];
14 extern unsigned char pal16bcl[1024];
15 extern unsigned char pal16bclha[1024];
16-extern unsigned char pal16bxcl[256];
17+extern unsigned char pal16bxcl[1024];
18 extern unsigned char SPCRAM[65472];
19 unsigned char *SPCState = SPCRAM;
20