tjh.dev
1Don't require python3 in PATH
2
3Once packaged, the arcanoid.py script has an absolute path shebang to
4python3, so there is no need to also require python3 in PATH.
5
6This prevents leaking in a python3 in PATH in the environment which arc
7runs linters etc.
8
9Author: bjorn.forsman@gmail.com
10diff -uNr arcanist.orig/src/workflow/ArcanistAnoidWorkflow.php arcanist.new/src/workflow/ArcanistAnoidWorkflow.php
11--- arcanist.orig/src/workflow/ArcanistAnoidWorkflow.php 2022-03-31 13:23:30.865095192 +0200
12+++ arcanist.new/src/workflow/ArcanistAnoidWorkflow.php 2022-04-01 12:19:15.644159639 +0200
13@@ -24,13 +24,6 @@
14 }
15
16 public function runWorkflow() {
17- if (!Filesystem::binaryExists('python3')) {
18- throw new PhutilArgumentUsageException(
19- pht(
20- 'The "arc anoid" workflow requires "python3" to be available '.
21- 'in your $PATH.'));
22- }
23-
24 $support_dir = phutil_get_library_root('arcanist');
25 $support_dir = dirname($support_dir);
26 $support_dir = $support_dir.'/support/';