The code works fine and works how it should be, the fix is just for uniformity/consistency of the bitwise operations and to fix a sparse warning: drivers/edac/skx_base.c:359:46: warning: dubious: x | !y lchan here is always 0 or 1 here, replace the inconsistent logical operator by xor operation. This removes the sparse warning and makes the switch case easier to read. [Tony: updated commit grammar and s/compiler warning/sparse warning/] Signed-off-by: Bryan Chan <bchimhim15@gmail.com> Signed-off-by: Tony Luck <tony.luck@intel.com> Link: https://patch.msgid.link/20260922231854.108188-1-bchimhim15@gmail.com