From 7d23f0f650d943f3f6bdd4635b43d66dcb7fb0a2 Mon Sep 17 00:00:00 2001 From: David Yang Date: Thu, 15 Oct 2026 08:44:19 +0800 Subject: [PATCH] net: dsa: motorcomm: Remove the redundant MIB clear The MIB clear in yt921x_chip_setup() is redundant. yt921x_dsa_setup() issues a hardware reset first, and the reset itself zeroes all the MIB counters. It does not follow the correct procedure either: CLEAN only takes effect while ALL_PORT is low, so a single-step CLEAN | ALL_PORT write does nothing once ALL_PORT is latched - and this write is what latches it for any CLEAN requested later. Signed-off-by: David Yang Reviewed-by: Andrew Lunn Link: https://patch.msgid.link/20261015004422.1554104-1-mmyangfl@gmail.com Signed-off-by: Paolo Abeni --- drivers/net/dsa/motorcomm/chip.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/dsa/motorcomm/chip.c b/drivers/net/dsa/motorcomm/chip.c index e2b5c89f7e77..d4fc20c52a58 100644 --- a/drivers/net/dsa/motorcomm/chip.c +++ b/drivers/net/dsa/motorcomm/chip.c @@ -2404,12 +2404,6 @@ static int yt921x_chip_setup(struct yt921x_priv *priv) return res; #endif - /* Clear MIB */ - ctrl = YT921X_MIB_CTRL_CLEAN | YT921X_MIB_CTRL_ALL_PORT; - res = yt921x_reg_write(priv, YT921X_MIB_CTRL, ctrl); - if (res) - return res; - /* Miscellaneous */ res = yt921x_reg_set_bits(priv, YT921X_SENSOR, YT921X_SENSOR_TEMP); if (res) -- knotmirror 0.0.1