From 761f34e333ace119eacc3af70fec87fceeb76dc0 Mon Sep 17 00:00:00 2001 From: Diederik de Haas Date: Fri, 4 Sep 2026 16:46:31 +0200 Subject: [PATCH] regulator: tps65185: Remove redundant dev_err_probe() The devm_request_threaded_irq() function now automatically logs detailed error messages on failure. This eliminates the need for driver-specific dev_err_probe() calls that print generic messages. Signed-off-by: Diederik de Haas Link: https://patch.msgid.link/20260904144728.1629471-1-diederik@cknow-tech.com Signed-off-by: Mark Brown --- drivers/regulator/tps65185.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/tps65185.c b/drivers/regulator/tps65185.c index 6a3130177e7a..4865227e444a 100644 --- a/drivers/regulator/tps65185.c +++ b/drivers/regulator/tps65185.c @@ -392,8 +392,7 @@ static int tps65185_probe(struct i2c_client *client) IRQF_TRIGGER_RISING | IRQF_ONESHOT, "PGOOD", data); if (ret) - return dev_err_probe(&client->dev, ret, - "failed to request power good irq\n"); + return ret; if (client->irq) { ret = devm_request_threaded_irq(&client->dev, client->irq, @@ -401,8 +400,7 @@ static int tps65185_probe(struct i2c_client *client) IRQF_TRIGGER_LOW | IRQF_ONESHOT, "tps65185", data); if (ret) - return dev_err_probe(&client->dev, ret, - "failed to request irq\n"); + return ret; } ret = regmap_update_bits(data->regmap, TPS65185_REG_INT_EN2, BIT(0), BIT(0)); -- knotmirror 0.0.1