From 6b56bb27466f1908462bc06bd06e3fc1848e5373 Mon Sep 17 00:00:00 2001 From: Paulo Alcantara Date: Sun, 11 Oct 2026 18:53:46 -0300 Subject: [PATCH] smb: client: remove write-only sec_kerberosu2u from TCP_Server_Info sec_kerberosu2u is set when the krb5 user-to-user OID is seen but is never read, so the OID branch that sets it has no effect. Drop both. Signed-off-by: Paulo Alcantara Reviewed-by: David Howells Cc: Namjae Jeon Cc: Ronnie Sahlberg Cc: Shyam Prasad N Cc: Tom Talpey Cc: Bharath SM --- fs/smb/client/asn1.c | 2 -- fs/smb/client/cifsglob.h | 1 - 2 files changed, 3 deletions(-) diff --git a/fs/smb/client/asn1.c b/fs/smb/client/asn1.c index 214a44509e7b..b610780c6802 100644 --- a/fs/smb/client/asn1.c +++ b/fs/smb/client/asn1.c @@ -46,8 +46,6 @@ int cifs_neg_token_init_mech_type(void *context, size_t hdrlen, oid = look_up_OID(value, vlen); if (oid == OID_mskrb5) server->sec_mskerberos = true; - else if (oid == OID_krb5u2u) - server->sec_kerberosu2u = true; else if (oid == OID_krb5) server->sec_kerberos = true; else if (oid == OID_ntlmssp) diff --git a/fs/smb/client/cifsglob.h b/fs/smb/client/cifsglob.h index 7c2ab3f56fae..65ed7a8fb574 100644 --- a/fs/smb/client/cifsglob.h +++ b/fs/smb/client/cifsglob.h @@ -752,7 +752,6 @@ struct TCP_Server_Info { char negflavor; /* NEGOTIATE response flavor */ /* extended security flavors that server supports */ bool sec_ntlmssp; /* supports NTLMSSP */ - bool sec_kerberosu2u; /* supports U2U Kerberos */ bool sec_kerberos; /* supports plain Kerberos */ bool sec_mskerberos; /* supports legacy MS Kerberos */ bool sec_iakerb; /* supports pass-through auth for Kerberos (krb5 proxy) */ -- knotmirror 0.0.1