Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

selftests/net: timestamping: Fix bind_phc check

timestamping checks socket options during initialisation. For the field
bind_phc of the socket option SO_TIMESTAMPING it expects the value -1 if
PHC is not bound. Actually the value of bind_phc is 0 if PHC is not
bound. This results in the following output:

SIOCSHWTSTAMP: tx_type 0 requested, got 0; rx_filter 0 requested, got 0
SO_TIMESTAMP 0
SO_TIMESTAMPNS 0
SO_TIMESTAMPING flags 0, bind phc 0
not expected, flags 0, bind phc -1

This is fixed by setting default value and expected value of bind_phc to
0.

Fixes: 2214d7032479 ("selftests/net: timestamping: support binding PHC")
Signed-off-by: Gerhard Engleder <gerhard@engleder-embedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Gerhard Engleder and committed by
David S. Miller
678dfd52 116ea68d

+2 -2
+2 -2
tools/testing/selftests/net/timestamping.c
··· 325 325 struct ifreq device; 326 326 struct ifreq hwtstamp; 327 327 struct hwtstamp_config hwconfig, hwconfig_requested; 328 - struct so_timestamping so_timestamping_get = { 0, -1 }; 329 - struct so_timestamping so_timestamping = { 0, -1 }; 328 + struct so_timestamping so_timestamping_get = { 0, 0 }; 329 + struct so_timestamping so_timestamping = { 0, 0 }; 330 330 struct sockaddr_in addr; 331 331 struct ip_mreq imr; 332 332 struct in_addr iaddr;