Something went wrong. Try again.
(I'm so sorry!) Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
Something went wrong. Try again.
9.1 kB · 203 lines
at master
123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204.. SPDX-License-Identifier: GPL-2.0
.. _Media Committers:
Media Committers================
Who is a Media Committer?-------------------------
A Media Committer is a Media Maintainer with patchwork access who has beengranted commit access to push patches from other developers and their ownpatches to the`media-committers <https://gitlab.freedesktop.org/linux-media/media-committers>`_tree.
These commit rights are granted with expectation of responsibility:committers are people who care about the Linux Kernel as a whole andabout the Linux media subsystem and want to advance its development. Itis also based on a trust relationship among other committers, maintainersand the Linux Media community.
As Media Committer you have the following additional responsibilities:
1. Patches you authored must have a ``Signed-off-by``, ``Reviewed-by`` or ``Acked-by`` from another Media Maintainer;2. If a patch introduces a regression, then that must be corrected as soon as possible. Typically the patch is either reverted, or an additional patch is committed to fix the regression;3. If patches are fixing bugs against already released Kernels, including the reverts mentioned above, the Media Committer shall add the needed tags. Please see :ref:`Media development workflow` for more details.4. All Media Committers are responsible for maintaining `Patchwork <https://patchwork.linuxtv.org/project/linux-media/list/>`_, updating the state of the patches they review or merge.
Becoming a Media Committer--------------------------
Existing Media Committers can nominate a Media Maintainer to be grantedcommit rights. The Media Maintainer must have patchwork access,have been reviewing patches from third parties for some time, and hasdemonstrated a good understanding of the maintainer's duties and processes.
The ultimate responsibility for accepting a nominated committer is up tothe Media Subsystem Maintainers. The nominated committer must have earned atrust relationship with all Media Subsystem Maintainers, as, by granting youcommit rights, part of their responsibilities are handed over to you.
Due to that, to become a Media Committer, a consensus between all MediaSubsystem Maintainers is required.
.. Note::
In order to preserve/protect the developers that could have their commit rights granted, denied or removed as well as the subsystem maintainers who have the task to accept or deny commit rights, all communication related to changing commit rights should happen in private as much as possible.
.. _media-committer-agreement:
Media Committer's agreement---------------------------
Once a nominated committer is accepted by all Media Subsystem Maintainers,they will ask if the developer is interested in the nomination and discusswhat area(s) of the media subsystem the committer will be responsible for.Those areas will typically be the same as the areas that the nominatedcommitter is already maintaining.
When the developer accepts being a committer, the new committer shallexplicitly accept the Kernel development policies described under itsDocumentation/, and in particular to the rules in this document, by writingan e-mail to media-committers@linuxtv.org, with a declaration of intentfollowing the model below::
I, John Doe, would like to change my status to: Committer
As Media Maintainer I accept commit rights for the following areas of the media subsystem:
...
For the purpose of committing patches to the media-committers tree, I'll be using my user https://gitlab.freedesktop.org/users/<username>.
Followed by a formal declaration of agreement with the Kernel developmentrules::
I agree to follow the Kernel development rules described at:
https://www.kernel.org/doc/html/latest/driver-api/media/media-committers.rst
and to the Linux Kernel development process rules.
I agree to abide by the Code of Conduct as documented in: https://www.kernel.org/doc/html/latest/process/code-of-conduct.rst
I am aware that I can, at any point of time, retire. In that case, I will send an e-mail to notify the Media Subsystem Maintainers for them to revoke my commit rights.
I am aware that the Kernel development rules change over time. By doing a new push to media-committers tree, I understand that I agree to follow the rules in effect at the time of the commit.
That e-mail shall be signed via the Kernel Web of trust with a PGP key crosssigned by other Kernel and media developers. As described at:ref:`media-developers-gpg`, the PGP signature, together with the gitlab usersecurity are fundamental components that ensure the authenticity of the mergerequests that will happen at the media-committers.git tree.
In case the kernel development process changes, by merging new commits to the`media-committers tree <https://gitlab.freedesktop.org/linux-media/media-committers>`_,the Media Committer implicitly declares their agreement with the latestversion of the documented process including the contents of this file.
If a Media Committer decides to retire, it is the committer's duty tonotify the Media Subsystem Maintainers about that decision.
.. note::
1. Changes to the kernel media development process shall be announced in the media-committers mailing list with a reasonable review period. All committers are automatically subscribed to that mailing list; 2. Due to the distributed nature of the Kernel development, it is possible that kernel development process changes may end being reviewed/merged at the Linux Docs and/or at the Linux Kernel mailing lists, especially for the contents under Documentation/process and for trivial typo fixes.
Media Core Committers---------------------
A Media Core Committer is a Media Core Maintainer with commit rights.
As described in Documentation/driver-api/media/maintainer-entry-profile.rst,a Media Core Maintainer maintains media core frameworks as well, besidesjust drivers, and so is allowed to change core files and the media subsystem'sKernel API. The extent of the core committer's grants will be detailed by theMedia Subsystem Maintainers when they nominate a Media Core Committer.
Existing Media Committers may become Media Core Committers and vice versa.Such decisions will be taken in consensus among the Media SubsystemMaintainers.
Media committers rules----------------------
Media committers shall do their best efforts to avoid merging patches thatwould break any existing drivers. If it breaks, fixup or revert patchesshall be merged as soon as possible, aiming to be merged at the same Kernelcycle the bug is reported.
Media committers shall behave accordingly to the rights granted bythe Media Subsystem Maintainers, especially with regards of the scope of changesthey may apply directly at the media-committers tree. That scope canchange over time on a mutual agreement between Media Committers andMedia Subsystem Maintainers.
The Media Committer workflow is described at :ref:`Media development workflow`.
.. _Maintain Media Status:
Maintaining Media Maintainer or Committer status------------------------------------------------
A community of maintainers working together to move the Linux Kernelforward is essential to creating successful projects that are rewardingto work on. If there are problems or disagreements within the community,they can usually be solved through healthy discussion and debate.
In the unhappy event that a Media Maintainer or Committer continues todisregard good citizenship (or actively disrupts the project), we may needto revoke that person's status. In such cases, if someone suggests therevocation with a good reason, then after discussing this among the MediaMaintainers, the final decision is taken by the Media Subsystem Maintainers.
As the decision to become a Media Maintainer or Committer comes from aconsensus between Media Subsystem Maintainers, a single Media SubsystemMaintainer not trusting the Media Maintainer or Committer anymore is enoughto revoke their maintenance, Patchwork grants and/or commit rights.
Having commit rights revoked doesn't prevent Media Maintainers to keepcontributing to the subsystem either via the pull request or via email workflowas documented at the :ref:`Media development workflow`.
If a maintainer is inactive for more than a couple of Kernel cycles,maintainers will try to reach you via e-mail. If not possible, they mayrevoke their maintainer/patchwork and committer rights and update MAINTAINERSfile entries accordingly. If you wish to resume contributing as maintainerlater on, then contact the Media Subsystem Maintainers to ask if yourmaintenance, Patchwork grants and commit rights can be restored.
References----------
Much of this was inspired by/copied from the committer policies of:
- `Chromium <https://chromium.googlesource.com/chromium/src/+/main/docs/contributing.md>`_;- `WebKit <https://webkit.org/commit-and-review-policy/>`_;- `Mozilla <https://www.mozilla.org/hacking/committer/>`_.