Add Spindle container image build #47

Open

psychedeli.ca 10mo ago

targeting main from psychedeli.ca/knot-docker:spindle

Open opened by and assigned to

psychedeli.ca 10mo ago targeting main from psychedeli.ca/knot-docker:spindle

Commits 8

add docs around variables

+15 -18

rename releases to all

+2 -2

add legacy releases task and info on how to build past releases

+50 -13

fix adduser/group commands in spindle stage

+2 -2

update readme to reference the spindle and document how to build images using docker bake

+43 -14

add docker bake config for building edge releases

+19

add spindle to docker-compose and configure builds for each image

+38 -7

add build stage for the spindle server

+34 -5

Comments

julien.rbrt.fr 11mo ago

Why not simply using a very simple Dockerfile, like this one for instance: https://tangled.org/strings/julien.rbrt.fr/3m75vdbmdad22

knotbin.com 11mo ago

It's unclear to me why this would be built into the knot docker repo. Not all knot hosters will want to host spindles.

psychedeli.ca 10mo ago

@julien.rbrt.fr all the dependencies and build commands are the same between the two tangled components so sharing their stages between builds makes building both of those programs faster.

@knotbin.com do you feel like the spindle image would be better off built in a different repo? my only reason for PRing here is so both the knot & spindle builds could take advantage of some dependency and artifact caching due to the multi-stage dockerfile. but if it’s better off in a different repo that’s fine too.

knotbin.com 10mo ago

i concur, I think this should be fine to merge once conflicts are fixed.

v0 10mo ago

Versions