From ffe32bbc6cbf2e7ea14790d8c22d151d4745ed8c Mon Sep 17 00:00:00 2001 From: yemou Date: Sat, 3 Jan 2026 13:03:34 -0500 Subject: [PATCH] appview/knots,spindles: ignore invalid handles when removing members This was preventing knot and spindle owners from removing members if the members's handle became invalid Fixes: https://tangled.org/tangled.org/core/issues/192 Signed-off-by: yemou --- appview/knots/knots.go | 5 ----- appview/spindles/spindles.go | 5 ----- 2 files changed, 10 deletions(-) diff --git a/appview/knots/knots.go b/appview/knots/knots.go index 8ee33389..ef702bb8 100644 --- a/appview/knots/knots.go +++ b/appview/knots/knots.go @@ -666,11 +666,6 @@ func (k *Knots) removeMember(w http.ResponseWriter, r *http.Request) { k.Pages.Notice(w, noticeId, "Failed to remove member, identity resolution failed.") return } - if memberId.Handle.IsInvalidHandle() { - l.Error("failed to resolve member identity to handle") - k.Pages.Notice(w, noticeId, "Failed to remove member, identity resolution failed.") - return - } // remove from enforcer err = k.Enforcer.RemoveKnotMember(domain, memberId.DID.String()) diff --git a/appview/spindles/spindles.go b/appview/spindles/spindles.go index 0a89d729..52bbd9a1 100644 --- a/appview/spindles/spindles.go +++ b/appview/spindles/spindles.go @@ -653,11 +653,6 @@ func (s *Spindles) removeMember(w http.ResponseWriter, r *http.Request) { s.Pages.Notice(w, noticeId, "Failed to remove member, identity resolution failed.") return } - if memberId.Handle.IsInvalidHandle() { - l.Error("failed to resolve member identity to handle") - s.Pages.Notice(w, noticeId, "Failed to remove member, identity resolution failed.") - return - } tx, err := s.Db.Begin() if err != nil { -- 2.52.0