From c5dc92f3f0c7b9e5f2d192f9aef2145becaf2250 Mon Sep 17 00:00:00 2001 From: Seongmin Lee Date: Wed, 19 Nov 2025 15:22:53 +0900 Subject: [PATCH] appview: follow web app manifest standard Change-Id: kuvknkxxvpvuxynzuspkwptlypsvomlz - `id` member in webmanifest should be url format based on spec. - it is recommended to use `application/mniafest+json` mimetype - changing the name from `pwa-manifest.json` to `manifest.webmanifest` Reference: Signed-off-by: Seongmin Lee --- appview/pages/templates/layouts/base.html | 4 ++-- appview/pages/templates/user/completeSignup.html | 2 +- appview/pages/templates/user/login.html | 2 +- appview/pages/templates/user/signup.html | 2 +- appview/state/router.go | 2 +- appview/state/state.go | 7 ++++--- 6 files changed, 10 insertions(+), 9 deletions(-) diff --git a/appview/pages/templates/layouts/base.html b/appview/pages/templates/layouts/base.html index 59675e98..fa7242e7 100644 --- a/appview/pages/templates/layouts/base.html +++ b/appview/pages/templates/layouts/base.html @@ -20,8 +20,8 @@ - - + + diff --git a/appview/pages/templates/user/completeSignup.html b/appview/pages/templates/user/completeSignup.html index 1f0e9744..a4981aff 100644 --- a/appview/pages/templates/user/completeSignup.html +++ b/appview/pages/templates/user/completeSignup.html @@ -20,7 +20,7 @@ content="complete your signup for tangled" /> - + - + login · tangled diff --git a/appview/pages/templates/user/signup.html b/appview/pages/templates/user/signup.html index 520fca86..9b496d57 100644 --- a/appview/pages/templates/user/signup.html +++ b/appview/pages/templates/user/signup.html @@ -8,7 +8,7 @@ - + sign up · tangled diff --git a/appview/state/router.go b/appview/state/router.go index 27d16e75..c1c90a3b 100644 --- a/appview/state/router.go +++ b/appview/state/router.go @@ -34,7 +34,7 @@ func (s *State) Router() http.Handler { router.Get("/favicon.ico", s.pages.StaticRedirect("/static/favicon.ico")) router.Get("/favicon.svg", s.pages.StaticRedirect("/static/favicon.svg")) - router.Get("/pwa-manifest.json", s.PWAManifest) + router.Get("/manifest.webmanifest", s.WebAppManifest) router.Get("/robots.txt", s.RobotsTxt) userRouter := s.UserRouter(&middleware) diff --git a/appview/state/state.go b/appview/state/state.go index ab1f1ae4..a8327c0f 100644 --- a/appview/state/state.go +++ b/appview/state/state.go @@ -213,6 +213,7 @@ Allow: / } // https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Manifest +// https://www.w3.org/TR/appmanifest/ const manifestJson = `{ "name": "tangled", "description": "tightly-knit social coding.", @@ -223,15 +224,15 @@ const manifestJson = `{ } ], "start_url": "/", - "id": "org.tangled", + "id": "https://tangled.org", "display": "standalone", "background_color": "#111827", "theme_color": "#111827" }` -func (p *State) PWAManifest(w http.ResponseWriter, r *http.Request) { - w.Header().Set("Content-Type", "application/json") +func (p *State) WebAppManifest(w http.ResponseWriter, r *http.Request) { + w.Header().Set("Content-Type", "application/manifest+json") w.Write([]byte(manifestJson)) } -- 2.43.0