tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview: allows a default knot to be configured #858

open
opened by willdot.net targeting master from willdot.net/tangled-core: master

This follows on from the work carried out in #836

I've added a select box in the Knots settings page which pulls in the users knots and also adds in knot1.tangled.sh. When the user selects one of these options, it will save to their profile in the database. NOTE: I haven't yet implemented adding that to the AT record because I'm not sure on how the lexicon setup works yet!

Then when users go to create a new repo / fork, if there is a value in their profile for the default knot, then that will pre select the knot to use for the new repo / fork.

0
by willdot.net 0 comments
expand 1 commit
fe49521e
appview: allows a default knot to be configured
sign up or login to add to the discussion
1
by willdot.net 0 comments
expand 2 commits
fe49521e
appview: allows a default knot to be configured
48ed4260
undo flake.lock change
sign up or login to add to the discussion
2
by willdot.net 6 comments
expand 3 commits
fe49521e
appview: allows a default knot to be configured
48ed4260
undo flake.lock change
3eae6087
appview: nil check when getting profile
oppi.li

valuable addition!

this strikes me more as a preference, i don't think this should go into the profile record however.

willdot.net

Do you mean the AT record or the database record?

I鈥檓 now doubting storing it in AT record because the default knot1.tangled.sh is only available in the tangled app view, not a 3rd party app view!

oppi.li

thanks for the work on this. comments:

  • can we squash all of this work into just one commit?
  • the PR also touches a few other template files, are these changes relevant to this addition? could we extract that to a different PR/commit?
oppi.li

will give this a quick test!

willdot.net

Oh I鈥檓 not sure why those files have changed. I鈥檒l revert them. Probably my IDE autoformat.

willdot.net

Ok squashed the commits into a single commit, which also removed the random files that had been changed from the diff 馃ぃ

sign up or login to add to the discussion
3
by willdot.net 0 comments
expand 1 commit
ead0762e
appview: allows a default knot to be configured
merge conflicts detected
sign up or login to add to the discussion
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:dadhhalkfcq3gucaq25hjqon/sh.tangled.repo.pull/3m7glmp44b322