tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/pages: auto-select knot when there's only one #836

merged opened by jordanreger.com targeting master from [deleted fork]: master

This adds the functionality to auto-select a knot if there's only one configured (usually knot1.tangled.sh).

It also makes the knot selection required in the fork process just like in the repository creation process.

Labels

None yet.

assignee

None yet.

Participants 3
AT URI
at://did:plc:27rjcwbur2bizjjx3zakeme5/sh.tangled.repo.pull/3m6g5pjg7mg22
-1
Interdiff #0 → #1
-1
appview/pages/templates/repo/fork.html
··· 25 25 value="{{ . }}" 26 26 class="mr-2" 27 27 id="domain-{{ . }}" 28 - required 29 28 {{if eq (len $.Knots) 1}}checked{{end}} 30 29 /> 31 30 <label for="domain-{{ . }}" class="dark:text-white">{{ . }}</label>
appview/pages/templates/repo/new.html

This file has not been changed.

History

2 rounds 5 comments
sign up or login to add to the discussion
jordanreger.com submitted #1
diff
1 commit
expand
0853638a
appview/pages: auto-select knot when there's only one
expand 4 comments
jordanreger.com

removed the commit to make the knot radio button input required

boltless.me

shouldn't we just always auto-select the first knot?

anirudh.fi

@boltless.me I think this is fine, since we can then have a default knot selection in the user settings.

jordanreger.com

Yeah this is just a temporary fix. Default knot settings feels like a larger feature that needs discussion first

pull request successfully merged
jordanreger.com submitted #0
diff
2 commits
expand
0853638a
appview/pages: auto-select knot when there's only one
8154612a
appview/pages: make repo fork knot selection required
expand 1 comment