tangled.org / core
Monorepo for Tangled tangled.org
fork atom

fix typo (get_deafult) in sh.tangled.repo.branches json response #805

merged opened by partially.dead.aylac.top targeting master from partially.dead.aylac.top/tangled-core: master
Labels

None yet.

assignee

None yet.

Participants 3
AT URI
at://did:plc:3c6vkaq7xf5kz3va3muptjh5/sh.tangled.repo.pull/3m5oqpmbnwt22
+1 -1
Diff #1
+1 -1
types/repo.go
··· 66 66 type Branch struct { 67 67 Reference `json:"reference"` 68 68 Commit *object.Commit `json:"commit,omitempty"` 69 - IsDefault bool `json:"is_deafult,omitempty"` 69 + IsDefault bool `json:"is_default,omitempty"` 70 70 } 71 71 72 72 type RepoTagsResponse struct {

History

2 rounds 4 comments
sign up or login to add to the discussion
partially.dead.aylac.top submitted #1
interdiff
1 commit
expand
bc5d4bf9
types: fix struct tag typo
expand 2 comments
oppi.li

this is a known issue but is a backwards incompatible change. ideally we would introduce a new field with the right spelling and then deprecate the old one after a few versions.

oppi.li

or support both names.

pull request successfully merged
partially.dead.aylac.top submitted #0
diff
1 commit
expand
f5c0fad0
fix typo
expand 2 comments
boltless.me

Thank you for your contribution! Can you please amend your commit following our contribution guidelines? Then I think we can merge it.

It should be something like

types: fix struct tag typo

{description}

Signed-off-by: Your Name <your.email@example.com>
partially.dead.aylac.top

oh ok done!!