tangled.org
To make it easier to get information about tangled repos, CORS need to be enabled on repo knots otherwise browsers will throw a fit. This change adds those headers. I think maybe the auth routes could do without them as right now it just gives it to all the routes.
Monorepo for Tangled
tangled.org
Add CORS top level middleware router to knotserver/ #735
merged
opened by
nekomimi.pet
targeting
master
from
[deleted fork]:
master
expand 2 commits
hide 2 commits
88684a67
knotserver/middleware.go: add cors headers as a middleware function
396baab5
knotserver/router.go: have top level router use cors header function
expand 2 commits
hide 2 commits
83963a3d
knotserver/middleware.go: add cors headers as a middleware function
Signed-off-by: @nekomimi.pet <ana@nekoimimi.pet>
729f7fce
knotserver/router.go: have top level router use cors header function
Signed-off-by: @nekomimi.pet <ana@nekoimimi.pet>
anirudh.fi
Awesome, this looks great! Tiny nit about the commits: they can simply be knotserver: … (exclude the filename, we only specify nested directories).
expand 2 commits
hide 2 commits
59a1308e
knotserver: add cors headers as a middleware function
Signed-off-by: @nekomimi.pet <ana@nekoimimi.pet>
b19de89d
knotserver: have top level router use cors header function
Signed-off-by: @nekomimi.pet <ana@nekoimimi.pet>
renamed commits
Amazing, merging!
pull request successfully merged
resubmitted to sign off on commits