Monorepo for Tangled tangled.org

appview/pages: seo improvements, sitemap, schemae and more #676

merged opened by anirudh.fi targeting master from push-wmkmzrsvlkmk
Labels
enhancement
assignee

None yet.

Participants 2
AT URI
at://did:plc:hwevmowznbiukdf6uk5dwrrq/sh.tangled.repo.pull/3m3afoejhnp22
+35 -12
Interdiff #2 #3
appview/pages/repoinfo/repoinfo.go

This file has not been changed.

appview/pages/templates/fragments/breadcrumb.html

This file has not been changed.

appview/pages/templates/fragments/dolly/logo.svg

This file has not been changed.

appview/pages/templates/goodfirstissues/index.html

This file has not been changed.

appview/pages/templates/layouts/base.html

This patch was likely rebased, as context lines do not match.

appview/pages/templates/layouts/profilebase.html

This file has not been changed.

appview/pages/templates/repo/index.html

This file has not been changed.

appview/pages/templates/repo/issues/fragments/og.html

This file has not been changed.

appview/pages/templates/repo/pulls/fragments/og.html

This file has not been changed.

appview/pages/templates/timeline/home.html

This file has not been changed.

appview/state/router.go

This patch was likely rebased, as context lines do not match.

+35 -12
appview/state/state.go
··· 208 209 robotsTxt := `User-agent: * 210 Allow: / 211 - ` 212 - w.Write([]byte(robotsTxt)) 213 - } 214 - 215 - func (s *State) TermsOfService(w http.ResponseWriter, r *http.Request) { 216 - user := s.oauth.GetMultiAccountUser(r) 217 - s.pages.TermsOfService(w, pages.TermsOfServiceParams{ 218 - 219 - 220 - 221 - robotsTxt := `User-agent: * 222 - Allow: / 223 Disallow: /settings 224 Disallow: /notifications 225 Disallow: /login ··· 278 } 279 280 // https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Manifest 281 const manifestJson = `{ 282 "name": "tangled",
··· 208 209 robotsTxt := `User-agent: * 210 Allow: / 211 Disallow: /settings 212 Disallow: /notifications 213 Disallow: /login ··· 266 } 267 268 // https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Manifest 269 + const manifestJson = `{ 270 + "name": "tangled", 271 + "description": "tightly-knit social coding.", 272 + "icons": [ 273 + { 274 + "src": "/favicon.svg", 275 + "sizes": "144x144" 276 + } 277 + ], 278 + "start_url": "/", 279 + "id": "org.tangled", 280 + 281 + "display": "standalone", 282 + "background_color": "#111827", 283 + "theme_color": "#111827" 284 + }` 285 + 286 + func (p *State) PWAManifest(w http.ResponseWriter, r *http.Request) { 287 + w.Header().Set("Content-Type", "application/json") 288 + w.Write([]byte(manifestJson)) 289 + } 290 + 291 + func (s *State) TermsOfService(w http.ResponseWriter, r *http.Request) { 292 + user := s.oauth.GetMultiAccountUser(r) 293 + s.pages.TermsOfService(w, pages.TermsOfServiceParams{ 294 + 295 + 296 + 297 + robotsTxt := `User-agent: * 298 + Allow: / 299 + ` 300 + w.Write([]byte(robotsTxt)) 301 + } 302 + 303 + // https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Manifest 304 const manifestJson = `{ 305 "name": "tangled",

History

5 rounds 2 comments
sign up or login to add to the discussion
1 commit
expand
appview/pages: seo improvements, sitemap, schemae and more
3/3 success
expand
expand 0 comments
pull request successfully merged
1 commit
expand
appview/pages: seo improvements, sitemap, schemae and more
3/3 success
expand
expand 0 comments
1 commit
expand
appview/pages: seo improvements, sitemap, schemae and more
3/3 success
expand
expand 0 comments
1 commit
expand
appview/pages: seo improvements, sitemap, schemae and more
3/3 success
expand
expand 0 comments
1 commit
expand
appview/pages: seo improvements, sitemap, schemae and more
3/3 success
expand
expand 2 comments
  • here, we don't need to calculate the language on the template side, we can do this similar to how repocards are implemented.
  • here seems a bit strange to generate all this json data on the template side, wouldn't it be easier to generate this as a func on models.Repo or repoinfo.Repoinfo?

this changeset looks good otherwise. i will look at the ancestor PRs shortly.

lower portion of the stack LGTM, merged!