appview: add support for latex in markdown #532

merged

opened by

handle.invalid 4 months ago targeting master from [deleted fork]: math

LaTeX support comes from https://github.com/Wyatt915/treeblood through https://github.com/Wyatt915/goldmark-treeblood.

I've gone through the Treeblood codebase (in its current state) and added every MathML attribute and element that it uses to the sanitizer. This means that there's a chance that Treeblood uses new elements/attributes in the future that aren't included in the current list, but as of Treeblood v0.1.15 I'm fairly sure everything is there.

goldmark-treeblood also caused the Goldmark version to be updated to v1.7.12, where it was previously on v1.4.15. I'm not sure if there was a specific reason why v1.4 was being used, or if it simply hadn't been updated, but I've updated that, and left all other dependencies untouched.

submitted by

handle.invalid 4mo 1 comment

diff

expand 1 commit

23c3f3fb

appview: add support for latex in markdown

oppi.li 4 months ago

looks pretty good! few comments:

could you update the commit message to follow the commit guidelines? just needs a sign off
this test does not render fully, i think the sanitizer needs to allow more elements. might be worth looking at trueblood and allowlisting all the elements it could emit

resubmitted by

handle.invalid 4mo 0 comments

diff interdiff

expand 3 commits

45ed7248

Fix lexicon schema for refUpdate

fe0f3329

knotserver: fix post-recieve handlers for new gitRefUpdate lexicon

e3cef9a7

appview: add support for latex in markdown

resubmitted by

handle.invalid 4mo 1 comment

diff interdiff

expand 1 commit

da02306f

appview: add support for latex in markdown

oppi.li 4 months ago

looks pretty good!

pull request successfully merged

Labels

None yet.

assignee

None yet.

Participants 2

AT URI

at://did:plc:s6urhemct6hiuyd5ytdlvnuw/sh.tangled.repo.pull/3lxdnucjnrb22