From 5f75d6f18a0ad35a42ce94370fb7cdbb7a978c92 Mon Sep 17 00:00:00 2001 From: Winter Date: Sat, 9 Aug 2025 19:07:58 -0400 Subject: [PATCH] knotserver: always show pipeline errors Change-Id: oxnqrpomulvwrqmoqrrxpwvpozkmoyry IMO, we shouldn't make errors opt-in to actually show upon push, at least not if/until we have a UI to show them to the user. Signed-off-by: Winter --- knotserver/internal.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/knotserver/internal.go b/knotserver/internal.go index 21473bf..e93644d 100644 --- a/knotserver/internal.go +++ b/knotserver/internal.go @@ -242,15 +242,15 @@ func (h *InternalHandle) triggerPipeline(clientMsgs *[]string, line git.PostRece return err } + for _, e := range compiler.Diagnostics.Errors { + *clientMsgs = append(*clientMsgs, e.String()) + } + if pushOptions.verboseCi { if compiler.Diagnostics.IsEmpty() { *clientMsgs = append(*clientMsgs, "success: pipeline compiled with no diagnostics") } - for _, e := range compiler.Diagnostics.Errors { - *clientMsgs = append(*clientMsgs, e.String()) - } - for _, w := range compiler.Diagnostics.Warnings { *clientMsgs = append(*clientMsgs, w.String()) } -- 2.43.0