knotserver/internal: emit CI SSH command conditionally #4260

Merged

oppi.li 4mo ago

targeting master from op/rumyvpqotoru

Merged opened by and assigned to

oppi.li 4mo ago targeting master from op/rumyvpqotoru

it was being emitted unconditionally, but now it only emits the command if there are a non-zero number of compiled workflows.

Signed-off-by: oppiliappan me@oppi.li

Commits 1

knotserver/internal: emit CI SSH command conditionally

+34 -25

Comments

boltless.me 4mo ago

imo Knot should know nothing about CI, at least it shouldn't even try to compile CI on its own.

One of the reasons to move CI trigger to spindle was to allow whatever trigger events / workflow definitions.

Also CI diagnostics from Knot doesn't make sense because that's not where it really happens.

oppi.li 4mo ago

yes, there is more discussion about this here: https://tangled.org/tangled.org/core/pulls/1924/round/1#comment-3mqbzeazl6g22

but this is a stopgap solution for now to keep the same behavior as pre-rework. ideally this flaw would have been accounted for before we changed up the model.

ptr.pet 4mo ago

knotserver/internal.go:274 we should pass compiled here and check len(compiled.Workflows) > 0 so we dont print the "success" if no workflows were compiled when diagnostics are empty

ptr.pet 4mo ago

or better, probably show "info: no pipelines to compile"

v0 4mo ago

Versions