tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview: introduce email notifications for @ mentions on issue/pr comments #393

closed opened by boltless.me targeting master from boltless.me/core: feat/mentions

Stacked on top of #392

Yes, I know we have stacked PRs, but I want to explicitly separate two sets of commits and review both on different places

This is MVC implementation of email notification.

Still lot of parts are missing, but this is a PR with most basic features.

Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3lvdu42ftpn22
+4 -6
Interdiff #1 → #2
appview/issues/issues.go

This file has not been changed.

appview/middleware/middleware.go

This patch was likely rebased, as context lines do not match.

appview/pulls/pulls.go

This patch was likely rebased, as context lines do not match.

appview/repo/artifact.go

This file has not been changed.

appview/repo/index.go

This file has not been changed.

appview/repo/repo.go

This patch was likely rebased, as context lines do not match.

appview/reporesolver/resolver.go

This patch was likely rebased, as context lines do not match.

appview/db/repos.go

This patch was likely rebased, as context lines do not match.

+3 -3
appview/state/state.go
··· 130 130 131 131 132 132 133 + 133 134 spindlestream.Start(ctx) 134 135 135 136 var notifiers []notify.Notifier 136 137 notifiers = append(notifiers, email.NewEmailNotifier(d, res, config)) 137 138 if !config.Core.Dev { 138 - notifiers = append(notifiers, posthog_service.NewPosthogNotifier(posthog)) 139 + notifiers = append(notifiers, posthogService.NewPosthogNotifier(posthog)) 139 140 } 140 141 141 142 ··· 393 394 394 395 395 396 396 - 397 397 // continue 398 398 } 399 399 400 + repo.AtUri = atresp.Uri 400 401 err = db.AddRepo(tx, repo) 401 402 if err != nil { 402 403 log.Println(err) ··· 411 412 // continue 412 413 } 413 414 414 - repo.AtUri = atresp.Uri 415 415 err = db.AddRepo(tx, repo) 416 416 if err != nil { 417 417 log.Println(err)
appview/pages/markup/markdown.go

This file has not been changed.

appview/pages/markup/markdown_at_extension.go

This file has not been changed.

appview/notify/merged_notifier.go

This file has not been changed.

appview/notify/notifier.go

This file has not been changed.

appview/posthog/notifier.go

This file has not been changed.

appview/email/notifier.go

This file has not been changed.

+1 -3
appview/db/star.go
··· 196 196 r.name, 197 197 r.knot, 198 198 r.rkey, 199 - r.created, 200 - r.at_uri 199 + r.created 201 200 from stars s 202 201 join repos r on s.repo_at = r.at_uri 203 202 `) ··· 222 221 &repo.Knot, 223 222 &repo.Rkey, 224 223 &repoCreatedAt, 225 - &repo.AtUri, 226 224 ); err != nil { 227 225 return nil, err 228 226 }

History

7 rounds 4 comments
sign up or login to add to the discussion
boltless.me submitted #6
diff interdiff
7 commits
expand
28409862
appview/pages: markup: add @ user-mention parsing in markdown
171488e2
appview: add NewIssueComment event
d3b193bb
appview: db/issues: set IssueId on GetIssue
1b5db515
appview: email: support multiple recipients on SendEmail
cad6e912
appview: email: send email notification on mention
4a8e0e3c
appview: settings: add email preference setting
732b33e8
appview: email: notify mentioned users on pull-comments
expand 1 comment
closed without merging
boltless.me submitted #5
diff interdiff
7 commits
expand
639df66d
appview/pages: markup: add @ user-mention parsing in markdown
79fbdb0c
appview: add NewIssueComment event
d82b5d26
appview: db/issues: set IssueId on GetIssue
0f21c183
appview: email: support multiple recipients on SendEmail
92817524
appview: email: send email notification on mention
85b487ca
appview: settings: add email preference setting
e4deb0f4
appview: email: notify mentioned users on pull-comments
expand 0 comments
boltless.me submitted #4
diff interdiff
7 commits
expand
05e23075
appview: reporesolver: pass entire Repo object through context
df874fc8
apview: replace all use of db.Repo.AtUri with db.Repo.RepoAt()
3413925b
appview: db/repos: remove AtUri from Repo
38014523
appview/pages: markup: add @ user-mention parsing in markdown
c3f41d5a
appview: add NewIssueComment event
0748a062
appview: email: send email notification on mention
e0000cba
appview: email: notify mentioned users on pull-comments
expand 0 comments
boltless.me submitted #3
diff interdiff
7 commits
expand
e33a63e7
appview: reporesolver: pass entire Repo object through context
26adbe09
apview: replace all use of db.Repo.AtUri with db.Repo.RepoAt()
0a65a3f9
appview: db/repos: remove AtUri from Repo
c247aea0
appview/pages: markup: add @ user-mention parsing in markdown
869804c1
appview: add NewIssueComment event
1b57d9e6
appview: email: send email notification on mention
c154972c
appview: email: notify mentioned users on pull-comments
expand 0 comments
boltless.me submitted #2
diff
7 commits
expand
5a3ea5b6
appview: reporesolver: pass entire Repo object through context
1654667a
apview: replace all use of db.Repo.AtUri with db.Repo.RepoAt()
55002a1e
appview: db/repos: remove AtUri from Repo
7c74733d
appview/pages: markup: add @ user-mention parsing in markdown
47ad1a3b
appview: add NewIssueComment event
886b401c
appview: email: send email notification on mention
efb0f1b3
appview: email: notify mentioned users on pull-comments
expand 0 comments
boltless.me submitted #1
diff interdiff
6 commits
expand
90679d26
appview: reporesolver: pass entire Repo object through context
3fbb4f0b
apview: replace all use of db.Repo.AtUri with db.Repo.RepoAt()
1b6628ab
appview/pages: markup: add @ user-mention parsing in markdown
34398af1
appview: add NewIssueComment event
8f874517
appview: email: send email notification on mention
5f2288c9
appview: email: notify mentioned users on pull-comments
expand 1 comment
boltless.me

@oppi.li I addressed your last two points. Thank you again for the detailed review.

for regex part, I'm not sure if we can share part of regex and modify by our needs.

boltless.me submitted #0
diff
7 commits
expand
90679d26
appview: reporesolver: pass entire Repo object through context
3fbb4f0b
apview: replace all use of db.Repo.AtUri with db.Repo.RepoAt()
1b6628ab
appview/pages: markup: add @ user-mention parsing in markdown
e1287c95
appview: add NewIssueComment event
18b248e5
appview: email: send email notification on mention
9eebc110
appview: email: add source to email notification
dfa71348
appview: email: notify mentioned users on pull-comments
expand 2 comments
oppi.li

i'd prefer if this was stacked! it would make it slightly easier to review:

  • in 1b6628ab: can we use the handle regex from the userutil module and customize it a bit for atRegex?
  • 18b248e5 and 9eebc110 seem to be modifying the same file, it would be nice to merge the two changes (running jj absorb when editing the second change should automatically solve it!).
  • similarly, dfa71348 seems to update the logic for issue-comment emails. would be nice to collapse or clean up the diffs.

this was only a first pass of reviews, but ill go through and have a closer look at the logic in the code, and give this a go locally. thanks again for working on this, its looking pretty cool already!

boltless.me

@oppi.li Thank you for the review!

and yeah I agree that I should have made this PR stacked.

Tell me if you think complete resubmission in form of stacked PR will be better.