From b36b03a3c938c538712c150849ae62c749a50503 Mon Sep 17 00:00:00 2001 From: dusk Date: Sun, 27 Jul 2025 12:44:58 +0300 Subject: [PATCH] knotserver: internal: extract push options from the headers, and implement skipping ci if skip-ci or ci-skip is passed Change-Id: prnxlqukyzkuwltoylruvunqkmmwrukx Signed-off-by: dusk Change-Id: prnxlqukyzkuwltoylruvunqkmmwrukx --- knotserver/internal.go | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/knotserver/internal.go b/knotserver/internal.go index 9450e87..143a517 100644 --- a/knotserver/internal.go +++ b/knotserver/internal.go @@ -64,6 +64,10 @@ func (h *InternalHandle) InternalKeys(w http.ResponseWriter, r *http.Request) { return } +type PushOptions struct { + skipCi bool +} + func (h *InternalHandle) PostReceiveHook(w http.ResponseWriter, r *http.Request) { l := h.l.With("handler", "PostReceiveHook") @@ -90,6 +94,15 @@ func (h *InternalHandle) PostReceiveHook(w http.ResponseWriter, r *http.Request) // non-fatal } + // extract any push options + pushOptionsRaw := r.Header.Values("X-Git-Push-Option") + pushOptions := PushOptions{} + for _, option := range pushOptionsRaw { + if option == "skip-ci" || option == "ci-skip" { + pushOptions.skipCi = true + } + } + for _, line := range lines { err := h.insertRefUpdate(line, gitUserDid, repoDid, repoName) if err != nil { @@ -97,7 +110,7 @@ func (h *InternalHandle) PostReceiveHook(w http.ResponseWriter, r *http.Request) // non-fatal } - err = h.triggerPipeline(line, gitUserDid, repoDid, repoName) + err = h.triggerPipeline(line, gitUserDid, repoDid, repoName, pushOptions) if err != nil { l.Error("failed to trigger pipeline", "err", err, "line", line, "did", gitUserDid, "repo", gitRelativeDir) // non-fatal @@ -148,7 +161,11 @@ func (h *InternalHandle) insertRefUpdate(line git.PostReceiveLine, gitUserDid, r return h.db.InsertEvent(event, h.n) } -func (h *InternalHandle) triggerPipeline(line git.PostReceiveLine, gitUserDid, repoDid, repoName string) error { +func (h *InternalHandle) triggerPipeline(line git.PostReceiveLine, gitUserDid, repoDid, repoName string, pushOptions PushOptions) error { + if pushOptions.skipCi { + return nil + } + didSlashRepo, err := securejoin.SecureJoin(repoDid, repoName) if err != nil { return err -- 2.43.0