appview/db: split star subjects #3117

Merged

boltless.me 11mo ago

targeting master

Merged opened by and assigned to

boltless.me 11mo ago targeting master

rename starred_by_did column to did
rename repo_at column to subject_at and removed foreign key constraints.
rename RepoAt field to SubjectAt
remove Repo field and split models.Star to RepoStar and StringStar as now there can be two kinds of reverse mappings.

Signed-off-by: Seongmin Lee git@boltless.me

This pull request has no versions submitted yet.

Comments

oppi.li 11mo ago

bit confusing that the repo_at col of the stars table can now refer to anything. can we rename that column too? to something more generic like target?

boltless.me 11mo ago

Actually that was my first intention, renaming repo_at to subject_at. I just didn't do that here because I was afraid to find all .repo_at usages in raw sql queries. And I thought that will also harder to review without tests.

Do you think it is worth renaming? If so, I can do that.

oppi.li 11mo ago

IIUC we'd only need to find repo_at for all queries that mention the "stars" table. searching for from stars might cover that. I'd recommend that we do fix this!