appview: implement pagination for pipelines index #2805

Closed

ptr.pet 1y ago

targeting master

Closed opened by and assigned to

ptr.pet 1y ago targeting master

Signed-off-by: dusk y.bera003.06@protonmail.com

This pull request has no versions submitted yet.

Comments

oppi.li 1y ago

on the whole this looks good, FilterBetween("row_num"...) is a bit magic because it is not possible to tell at a glance that row_num is a column of pipelines, but until we land on a good mechanism for a generic interface for paginating db responses, this is perfect.

thanks for working on this!

ptr.pet 1y ago

had to rename filter to Filter since i wanted to use it elsewhere, but otherwise mostly the same aside from the changes from #519

oppi.li 11mo ago

i think i'd like to rework this from scratch, unfortunately theres been plenty of codechurn around this part of the code over the past few weeks.