tangled.org
right now the button's text gets added without the around it. can't figure out why. am i missing sth obvious ?
Monorepo for Tangled
tangled.org
improve code blocks in markdown (syntax highlighting and copy-to-clipboard button) #145
closed
opened by
gwen.works
targeting
master
from
gwen.works/core:
copycodeblocks
expand 3 commits
hide 3 commits
deps: add goldmark-highlighting
appview: highlight rendered markdown code blocks
(wip)appview: add copy button
right now, only the textnode inside the button gets added, without the
<button> around it. can't figure out why. the DataAtom and Type match
what html.Parse gives, per https://go.dev/play/p/eW2o3v2eBbY
expand 5 commits
hide 5 commits
deps: add goldmark-highlighting
appview: highlight rendered markdown code blocks
appview: post-process rendered markdown after sanitization
also ensures that every (RunContext).RenderMarkdown callsite gets back a
sanitized value (or very loudly decides not to sanitize by passing e.g.
func(s string) string { return s } as the sanitizer argument)
appview: hide [aria-hidden="true"] elements
(wip)appview: add copy button
right now, only the textnode inside the button gets added, without the
<button> around it. can't figure out why. the DataAtom and Type match
what html.Parse gives, per https://go.dev/play/p/eW2o3v2eBbY
expand 5 commits
hide 5 commits
deps: add goldmark-highlighting
appview: markup: highlight rendered markdown code blocks
appview: pages: post-process rendered markdown after sanitization
also ensures that every (RunContext).RenderMarkdown callsite gets back a
sanitized value (or very loudly decides not to sanitize by passing e.g.
func(s string) string { return s } as the sanitizer argument)
appview: input.css: hide [aria-hidden="true"] elements
(wip)appview: markup: add copy button to markdown code blocks
closes #103
round #2 is just my dumb ass making commit messages conform with the contributing guide
expand 6 commits
hide 6 commits
deps: add goldmark-highlighting
appview: markup: highlight rendered markdown code blocks
appview: pages: post-process rendered markdown after sanitization
also ensures that every (RunContext).RenderMarkdown callsite gets back a
sanitized value (or very loudly decides not to sanitize by passing e.g.
func(s string) string { return s } as the sanitizer argument)
appview: input.css: hide [aria-hidden="true"] elements
(wip)appview: markup: add copy button to markdown code blocks
closes #103
(to-revert)appview: markup: work around the fact that [onload] is cringe
expand 6 commits
hide 6 commits
deps: add goldmark-highlighting
Signed-off-by: Gwenn Le Bihan <gwenn.lebihan7@gmail.com>
appview: markup: highlight rendered markdown code blocks
Signed-off-by: Gwenn Le Bihan <gwenn.lebihan7@gmail.com>
appview: pages: post-process rendered markdown after sanitization
Signed-off-by: Gwenn Le Bihan <gwenn.lebihan7@gmail.com>
also ensures that every (RunContext).RenderMarkdown callsite gets back a
sanitized value (or very loudly decides not to sanitize by passing e.g.
func(s string) string { return s } as the sanitizer argument)
appview: input.css: hide [aria-hidden="true"] elements
Signed-off-by: Gwenn Le Bihan <gwenn.lebihan7@gmail.com>
(wip)appview: markup: add copy button to markdown code blocks
closes #103
Signed-off-by: Gwenn Le Bihan <gwenn.lebihan7@gmail.com>
(to-revert)appview: markup: work around the fact that [onload] is cringe
Signed-off-by: Gwenn Le Bihan <gwenn.lebihan7@gmail.com>
round #4: sign-off commits and rebase atop main
expand 6 commits
hide 6 commits
deps: add goldmark-highlighting
Signed-off-by: Gwenn Le Bihan <gwenn.lebihan7@gmail.com>
appview: markup: highlight rendered markdown code blocks
Signed-off-by: Gwenn Le Bihan <gwenn.lebihan7@gmail.com>
appview: pages: post-process rendered markdown after sanitization
Signed-off-by: Gwenn Le Bihan <gwenn.lebihan7@gmail.com>
also ensures that every (RunContext).RenderMarkdown callsite gets back a
sanitized value (or very loudly decides not to sanitize by passing e.g.
func(s string) string { return s } as the sanitizer argument)
appview: input.css: hide [aria-hidden="true"] elements
Signed-off-by: Gwenn Le Bihan <gwenn.lebihan7@gmail.com>
(wip)appview: markup: add copy button to markdown code blocks
closes #103
Signed-off-by: Gwenn Le Bihan <gwenn.lebihan7@gmail.com>
(to-revert)appview: markup: work around the fact that [onload] is cringe
Signed-off-by: Gwenn Le Bihan <gwenn.lebihan7@gmail.com>
oppi.li
is this still being worked on? (i see some wip commits)
(no rush whatsoever, just checking in to see if i can help in any way!)
yeah sorry for the whole-month silence lol, its mostly tailwind shenanigans and i had to work around it and it's quite ugly
there was also the thing with sanitizing user html later, ill try to finish it over the weekend, idk how much conflicted i have become with main lol (long running feature branches = hell)
uncenter.dev
FYI there is another person working on just the syntax highlighting side of things, see Discord: https://discord.com/channels/1361963801993285692/1392475067962753116.
closing this now, syntax highlighting in md blocks has been added.
closed without merging
i uhhh meant "without the <button> around it", cant edit pr body