Monorepo for Tangled tangled.org

appview/pages: reset label & secret form correctly #1310

merged opened by tobinio.dev targeting master from tobinio.dev/core: form-resetting

Based on what I can tell after-request is not triggered because the response causes a full page reload and the persisted input values were due to browser autofill, not htmx state.

Resolves: https://tangled.org/tangled.org/core/issues/260

Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:skn5vraxgldxskx4eubsvg4h/sh.tangled.repo.pull/3mjbsjmkxzl22
+3 -2
Diff #1
+2 -2
appview/pages/templates/repo/settings/fragments/addLabelDefModal.html
··· 28 28 29 29 {{ define "basicLabelDef" }} 30 30 <form 31 + autocomplete="off" 31 32 hx-put="/{{ $.RepoInfo.FullName }}/settings/label" 32 33 hx-indicator="#spinner" 33 34 hx-swap="none" 34 - hx-on::after-request="if(event.detail.successful) this.reset()" 35 35 class="flex flex-col space-y-4"> 36 36 37 37 <p class="text-gray-500 dark:text-gray-400">These labels can have a name and a color.</p> ··· 49 49 50 50 {{ define "kvLabelDef" }} 51 51 <form 52 + autocomplete="off" 52 53 hx-put="/{{ $.RepoInfo.FullName }}/settings/label" 53 54 hx-indicator="#spinner" 54 55 hx-swap="none" 55 - hx-on::after-request="if(event.detail.successful) this.reset()" 56 56 class="flex flex-col space-y-4"> 57 57 58 58 <p class="text-gray-500 dark:text-gray-400">
+1
appview/pages/templates/repo/settings/pipelines.html
··· 104 104 105 105 {{ define "addSecretModal" }} 106 106 <form 107 + autocomplete="off" 107 108 hx-put="/{{ $.RepoInfo.FullName }}/settings/secrets" 108 109 hx-indicator="#spinner" 109 110 hx-swap="none"

History

2 rounds 1 comment
sign up or login to add to the discussion
1 commit
expand
appview/pages: reset label & secret form correctly
expand 1 comment
pull request successfully merged
1 commit
expand
appview/pages: reset label & secret form correctly
expand 0 comments