tangled.org
use com.atproto.repo.strongRef for more explicit reference &
markup#markdown type to give clear semantic meaning in markdown
Close: https://tangled.org/tangled.org/core/issues/383 Signed-off-by: Seongmin Lee git@boltless.me
api/tangled/cbor_gen.go
api/tangled/cbor_gen.go
Failed to calculate interdiff for this file.
api/tangled/feedcomment.go
api/tangled/feedcomment.go
This file has not been changed.
api/tangled/markupmarkdown.go
api/tangled/markupmarkdown.go
This file has not been changed.
api/tangled/tangledcomment.go
api/tangled/tangledcomment.go
This file has not been changed.
cmd/cborgen/cborgen.go
cmd/cborgen/cborgen.go
This file has not been changed.
lexicon-build-config.json
lexicon-build-config.json
This file has not been changed.
lexicons/com/atproto/repo/strongRef.json
lexicons/com/atproto/repo/strongRef.json
This file has not been changed.
+19
-11
lexicons/comment/comment.json
+19
-11
lexicons/comment/comment.json
···
1
1
{
2
2
"lexicon": 1,
3
+
"id": "sh.tangled.comment",
3
-
"id": "sh.tangled.feed.comment",
4
4
"needsCbor": true,
5
5
"needsType": true,
6
6
"defs": {
···
16
16
],
17
17
"properties": {
18
18
"subject": {
19
+
"type": "string",
20
+
"format": "at-uri"
19
-
"type": "ref",
20
-
"ref": "com.atproto.repo.strongRef"
21
21
},
22
22
"body": {
23
+
"type": "string"
23
-
"type": "union",
24
-
"refs": ["sh.tangled.markup.markdown"]
25
24
},
26
25
"createdAt": {
27
26
"type": "string",
28
27
"format": "datetime"
29
28
},
30
29
"replyTo": {
30
+
"type": "string",
31
+
"format": "at-uri"
32
+
},
33
+
"mentions": {
34
+
"type": "array",
35
+
"items": {
36
+
"type": "string",
37
+
"format": "did"
38
+
}
31
-
"type": "ref",
32
-
"ref": "com.atproto.repo.strongRef"
33
39
},
40
+
"references": {
41
+
"type": "array",
42
+
"items": {
43
+
"type": "string",
44
+
"format": "at-uri"
45
+
}
34
-
"pullRoundIdx": {
35
-
"type": "integer",
36
-
"minimum": 1,
37
-
"description": "optional pull submission round index. required when subject is sh.tangled.repo.pull"
38
46
}
39
47
}
40
48
}
lexicons/markup/markdown.json
lexicons/markup/markdown.json
This file has not been changed.
+11
-19
lexicons/feed/comment.json
+11
-19
lexicons/feed/comment.json
···
1
1
{
2
2
"lexicon": 1,
3
-
"id": "sh.tangled.comment",
3
+
"id": "sh.tangled.feed.comment",
4
4
"needsCbor": true,
5
5
"needsType": true,
6
6
"defs": {
···
16
16
],
17
17
"properties": {
18
18
"subject": {
19
-
"type": "string",
20
-
"format": "at-uri"
19
+
"type": "ref",
20
+
"ref": "com.atproto.repo.strongRef"
21
21
},
22
22
"body": {
23
-
"type": "string"
23
+
"type": "union",
24
+
"refs": ["sh.tangled.markup.markdown"]
24
25
},
25
26
"createdAt": {
26
27
"type": "string",
27
28
"format": "datetime"
28
29
},
29
30
"replyTo": {
30
-
"type": "string",
31
-
"format": "at-uri"
32
-
},
33
-
"mentions": {
34
-
"type": "array",
35
-
"items": {
36
-
"type": "string",
37
-
"format": "did"
38
-
}
31
+
"type": "ref",
32
+
"ref": "com.atproto.repo.strongRef"
39
33
},
40
-
"references": {
41
-
"type": "array",
42
-
"items": {
43
-
"type": "string",
44
-
"format": "at-uri"
45
-
}
34
+
"pullRoundIdx": {
35
+
"type": "integer",
36
+
"minimum": 0,
37
+
"description": "optional pull submission round index. required when subject is sh.tangled.repo.pull"
46
38
}
47
39
}
48
40
}
History
10 rounds
2 comments
boltless.me
submitted
#9
1 commit
expand
collapse
lexicons:
com.atproto.repo.strongRef and sh.tangled.markup.markdown
use `com.atproto.repo.strongRef` for more explicit reference &
`markup.markdown` type to give clear semantic meaning in markdown
Close: <https://tangled.org/tangled.org/core/issues/383>
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 failed
expand
collapse
no conflicts, ready to merge
expand 0 comments
boltless.me
submitted
#8
1 commit
expand
collapse
lexicons:
com.atproto.repo.strongRef and sh.tangled.markup.markdown
use `com.atproto.repo.strongRef` for more explicit reference &
`markup.markdown` type to give clear semantic meaning in markdown
Close: <https://tangled.org/tangled.org/core/issues/383>
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 failed
expand
collapse
expand 0 comments
boltless.me
submitted
#7
1 commit
expand
collapse
lexicons:
com.atproto.repo.strongRef and sh.tangled.markup.markdown
use `com.atproto.repo.strongRef` for more explicit reference &
`markup.markdown` type to give clear semantic meaning in markdown
Close: <https://tangled.org/tangled.org/core/issues/383>
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 failed
expand
collapse
expand 0 comments
boltless.me
submitted
#6
1 commit
expand
collapse
lexicons:
com.atproto.repo.strongRef and sh.tangled.markup.markdown
use `com.atproto.repo.strongRef` for more explicit reference &
`markup.markdown` type to give clear semantic meaning in markdown
Close: <https://tangled.org/tangled.org/core/issues/383>
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 failed
expand
collapse
expand 0 comments
boltless.me
submitted
#5
1 commit
expand
collapse
lexicons:
com.atproto.repo.strongRef and sh.tangled.markup.markdown
use `com.atproto.repo.strongRef` for more explicit reference &
`markup.markdown` type to give clear semantic meaning in markdown
Close: <https://tangled.org/tangled.org/core/issues/383>
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 failed
expand
collapse
expand 0 comments
boltless.me
submitted
#4
1 commit
expand
collapse
lexicons:
com.atproto.repo.strongRef and sh.tangled.markup.markdown
use `com.atproto.repo.strongRef` for more explicit reference &
`markup.markdown` type to give clear semantic meaning in markdown
Close: <https://tangled.org/tangled.org/core/issues/383>
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 failed
expand
collapse
expand 0 comments
boltless.me
submitted
#3
1 commit
expand
collapse
lexicons:
com.atproto.repo.strongRef and sh.tangled.markup.markdown
use `com.atproto.repo.strongRef` for more explicit reference &
`markup.markdown` type to give clear semantic meaning in markdown
Close: <https://tangled.org/tangled.org/core/issues/383>
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 failed
expand
collapse
expand 0 comments
boltless.me
submitted
#2
1 commit
expand
collapse
lexicons:
com.atproto.repo.strongRef and sh.tangled.markup.markdown
use `com.atproto.repo.strongRef` for more explicit reference &
`markup.markdown` type to give clear semantic meaning in markdown
Close: <https://tangled.org/tangled.org/core/issues/383>
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 failed
expand
collapse
boltless.me
submitted
#1
1 commit
expand
collapse
lexicons:
com.atproto.repo.strongRef and sh.tangled.markup#markdown
use `com.atproto.repo.strongRef` for more explicit reference &
`markup#markdown` type to give clear semantic meaning in markdown
Close: <https://tangled.org/tangled.org/core/issues/383>
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 failed
expand
collapse
expand 0 comments
boltless.me
submitted
#0
1 commit
expand
collapse
lexicons:
com.atproto.repo.strongRef and sh.tangled.markup#markdown
use `com.atproto.repo.strongRef` for more explicit reference &
`markup#markdown` type to give clear semantic meaning in markdown
Close: <https://tangled.org/tangled.org/core/issues/383>
Signed-off-by: Seongmin Lee <git@boltless.me>
lexicons/comment/comment.json:36what about round 0