tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/notify: add Clone notifier, enqueue posthog event for clones #1265

merged opened by anirudh.fi targeting master from icy/prsznk
STACK 2
#1266 appview/notify: move logging and webhook notifiers to their own packages
0/3
2
#2
#1265 appview/notify: add Clone notifier, enqueue posthog event for clones
0/3
2
#2
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:hwevmowznbiukdf6uk5dwrrq/sh.tangled.repo.pull/3miisjgqysp22
Interdiff #1 → #2
appview/notify/db/db.go

This file has not been changed.

appview/notify/logging_notifier.go

This file has not been changed.

appview/notify/merged_notifier.go

This file has not been changed.

appview/notify/notifier.go

This file has not been changed.

appview/notify/posthog/notifier.go

This file has not been changed.

appview/notify/webhook_notifier.go

This file has not been changed.

appview/state/git_http.go

This patch was likely rebased, as context lines do not match.

History

3 rounds 2 comments
sign up or login to add to the discussion
anirudh.fi submitted #2
diff
1 commit
expand
a5e37ed0
appview/notify: add Clone notifier, enqueue posthog event for clones
3/3 failed
expand
build.yml
fmt.yml
test.yml
expand 0 comments
pull request successfully merged
anirudh.fi submitted #1
diff interdiff
1 commit
expand
f380c341
appview/notify: add Clone notifier, enqueue posthog event for clones
1/3 failed, 1/3 timeout, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
anirudh.fi submitted #0
diff
1 commit
expand
7ce56045
appview/notify: add Clone notifier, enqueue posthog event for clones
expand 2 comments
boltless.me

appview/state/git_http.go:57 I think it will be fine in most cases, but shouldn't we use context.Background() here?

otherwise lgtm!

anirudh.fi

Good catch; it might be racy, although it's very likely that the Posthog request completes before the clone does.