tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/pages/templates/repo/pulls: add collapse comments button #1229

merged opened by eti.tf targeting master from eti.tf/core: eti/tan-363-comments-thread-collapse-indicator

Add a "collapse comments" button because the previous and only way to collapse them, the vertical line, was not always obvious.

collapse comments in action

Signed-off-by: eti eti@eti.tf

Labels

None yet.

assignee

None yet.

Participants 3
AT URI
at://did:plc:xu5apv6kmu5jp7g5hwdnej42/sh.tangled.repo.pull/3mi2zf6ddx622
+1 -1
Interdiff #0 → #1
+1 -1
appview/pages/templates/repo/pulls/pull.html
··· 570 570 </div> 571 571 {{ if gt $c 0}} 572 572 <button class="flex items-center gap-2 -ml-2 relative cursor-pointer text-sm text-gray-500 dark:text-gray-400 group-hover/collapse:text-gray-600 dark:group-hover/collapse:text-gray-300 bg-gray-50 mt-4 pb-4 transition-colors" hx-on:click="this.closest('details').open = false"> 573 - {{ i "chevron-up" "size-4 z-5" }} collapse comments 573 + {{ i "circle-chevron-up" "size-4 z-5" }} collapse comment{{ if ne $c 1 }}s{{ end }} 574 574 </button> 575 575 {{ end }} 576 576

History

2 rounds 5 comments
sign up or login to add to the discussion
eti.tf submitted #1
diff
1 commit
expand
e7c77b8b
appview/pages/templates/repo/pulls: add collapse comments button
expand 1 comment
pull request successfully merged
eti.tf submitted #0
diff
1 commit
expand
f3898ebc
appview/pages/templates/repo/pulls: add collapse comments button
expand 4 comments
oyster.cafe

Noice! LGTM

oppi.li

lgtm, should we have a similar chevron-down for expand comments?

eti.tf

how about that @oppi.li?

eti.tf

i like the original look with the circle-plus icon, it feels fun tbh what my previous message proposes is to switch the chevron-up with a circle-chevron-up to keep that circle visual pattern both ways 🙂‍↕️