tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/pages/templates/repo/pulls: improve current round styling and contrast #1221

merged opened by eti.tf targeting master from eti.tf/core: eti/tan-355-current-round-selection-indicator

Update the styling for pull request rounds cards to provide better distinction between active and inactive rounds. Changes include:

  • Better background colors for active rounds (blue tint)
  • Improved text contrast in both light and dark modes
  • Consistent border handling and overflow clipping

the changes in light mode

the changes in dark mode

Signed-off-by: eti eti@eti.tf

Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xu5apv6kmu5jp7g5hwdnej42/sh.tangled.repo.pull/3mhxwojrh3d22
Interdiff #2 → #3
appview/pages/templates/repo/pulls/pull.html

This file has not been changed.

History

5 rounds 5 comments
sign up or login to add to the discussion
eti.tf submitted #4
diff interdiff
1 commit
expand
45309cd7
appview/pages/templates/repo/pulls: improve round styling and contrast
expand 0 comments
pull request successfully merged
eti.tf submitted #3
diff
1 commit
expand
ba3a36ba
appview/pages/templates/repo/pulls: improve round styling and contrast
expand 2 comments
eti.tf

@oppi.li squashed!

oppi.li

lgtm barring merge conflicts! please do rebase when you do fixup the conflicts!

eti.tf submitted #2
diff interdiff
2 commits
expand
86c9d0d1
appview/pages/templates/repo/pulls: improve round styling and contrast
c3e50e12
appview/pages/templates/repo/pulls: fix non-current round card bg color regression & add back missing hunk
expand 0 comments
eti.tf submitted #1
diff interdiff
2 commits
expand
67bd0f03
appview/pages/templates/repo/pulls: improve round styling and contrast
9fa0f667
appview/pages/templates/repo/pulls: fix non-current round card bg color regression & add back missing hunk
expand 1 comment
oppi.li

thanks! can you squash and rebase?

eti.tf submitted #0
diff
1 commit
expand
67bd0f03
appview/pages/templates/repo/pulls: improve round styling and contrast
expand 2 comments
oppi.li

largely lgtm!

appview/pages/templates/repo/pulls/pull.html:103-105: why was this hunk removed?

eti.tf

oops, that wasn't supposed to happen. let me add it back.

i also noticed a regression with how non-selected rounds look. i'll resubmit soon w a fix