tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview,knotserver/xrpc: create repo on knot-side first #1206

deleted opened by boltless.me targeting master from sl/rvyxvsnxkkql

Because knotmirror is listening to creation of sh.tangled.repo records, the actual git repository should exist on sh.tangled.repo creation event.

Signed-off-by: Seongmin Lee git@boltless.me

STACK 3
#1202 knotserver,knotmirror/xrpc: sync.requestCrawl support
1/3
4
#6
#1201 lexicons: sync.requestCrawl and knot.subscribeRepos
1/3
0
#6
#1200 nix,knotmirror: listen & sync local knots from local knotmirror
1/3
0
#6
ABANDONED PULLS 13
#1206 appview,knotserver/xrpc: create repo on knot-side first
3
#1
#1205 lexicons: add required name field to repo.create
0
#1
#1203 nix,knotmirror: sync localhost knots
0
#1
#1199 appview: remove oauth.User type
3/3
0
#0
#1198 appview/pulls: remove dependencies to oauth.MultiAccountUser
2/3
0
#0
#1197 appview/pages: don't access MultiAccountUser.Active from template
2/3
0
#0
#1196 appview/oauth: remove .Handle from oauth.AccountInfo
2/3
0
#0
#1195 appview/oauth: remove AuthReturnInfo
2/3
0
#0
#1194 appview/{oauth,pages,state}: remove unused AddAccount session data
2/3
0
#0
#1193 appview/{pages,state}: simplify LoginPage params
2/3
0
#0
#1192 appview/{oauth,pages}: cleanup unused codes
2/3
0
#0
#1191 appview: don't trust oauth.ClientSessionData
2/3
0
#0
#1190 appview: use explicit TANGLED_PDS_USER_DOMAIN for user handle check
2/3
0
#0
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3mhl5w55wch22
Interdiff #0 → #1
appview/state/state.go

This file has not been changed.

knotserver/xrpc/create_repo.go

This file has not been changed.

History

2 rounds 3 comments
sign up or login to add to the discussion
boltless.me submitted #1
diff
1 commit
expand
6f3a960d
appview,knotserver/xrpc: create repo on knot-side first
expand 3 comments
oppi.li

you you explain the transaction rollback steps here? if the record creation fails will the knot have the directory created inside it?

boltless.me

Ah, right, so that was why we were creating PDS records first. I will bring @oyster.cafe's work to support that.

#1140 appview/state/state.go:511-544

oppi.li

makes sense, in which case, we can abandon this PR and live with the slight delay for now!

This pull has been deleted (possibly by jj abandon or jj squash)
boltless.me submitted #0
diff
1 commit
expand
202b0509
appview,knotserver/xrpc: create repo on knot-side first
expand 0 comments