Overview#
This pr implements the first part of this proposal and introduces two new environment variables.
- UploadWorkflowLogs, is set to true then the workflow's logs will be uploaded to s3
- LogsBucket, specifies the logs bucket Stores workflow logs in s3
nice! couple of comments from my end (note that i have not yet tested this out myself locally):
spindle/config/config.go:42-43: i think the config option should be its own struct, and not in NixeryPipelines. we can havetype S3 struct { .. }with justLogBucketas the only option. ifLogBucketis the empty string, we can consider s3 to be disabled, and if not, we can consider it to be enabled.spindle/engines/nixery/engine.go:290: spindle is structured to have multiple engines, of which nixery is one engine (and the only one presently). uploading logs here would mean future engines will have to duplicate this step. this logic is better implemented inengine/engine.gospindle/utils/s3.go:1: i personally try to avoid autilspackage. this could live at the top level IMO:spindle/s3.go.