Signed-off-by: Seongmin Lee git@boltless.me
+8
-5
Diff
round #2
+8
-5
appview/repo/index.go
+8
-5
appview/repo/index.go
···
112
112
l.Error("failed to GetVerifiedObjectCommits", "err", err)
113
113
}
114
114
115
-
// TODO: a bit dirty
116
-
languageInfo, err := rp.getLanguageInfo(r.Context(), l, f, result.Ref, ref == "")
117
-
if err != nil {
118
-
l.Warn("failed to compute language percentages", "err", err)
119
-
// non-fatal
115
+
var languageInfo []types.RepoLanguageDetails
116
+
if !result.IsEmpty {
117
+
// TODO: a bit dirty
118
+
languageInfo, err = rp.getLanguageInfo(r.Context(), l, f, result.Ref, ref == "")
119
+
if err != nil {
120
+
l.Warn("failed to compute language percentages", "err", err)
121
+
// non-fatal
122
+
}
120
123
}
121
124
122
125
var shas []string
History
3 rounds
0 comments
boltless.me
submitted
#2
1 commit
expand
collapse
appview/repo: avoid extra xrpc call on empty repo
Signed-off-by: Seongmin Lee <git@boltless.me>
2/3 timeout, 1/3 success
expand
collapse
expand 0 comments
pull request successfully merged
boltless.me
submitted
#1
1 commit
expand
collapse
appview/repo: avoid extra xrpc call on empty repo
Signed-off-by: Seongmin Lee <git@boltless.me>
expand 0 comments
boltless.me
submitted
#0
1 commit
expand
collapse
appview/repo: avoid extra xrpc call on empty repo
Signed-off-by: Seongmin Lee <git@boltless.me>