Monorepo for Tangled tangled.org

appview: update state, ingester, middleware, and resolver for repo DID #1140

open opened by oyster.cafe targeting master from oyster.cafe/tangled-core: master
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:3fwecdnvtcscjnrx2p4n7alz/sh.tangled.repo.pull/3mgprvt2eon22
+3 -9
Interdiff #3 #4
appview/ingester.go

This file has not been changed.

appview/middleware/middleware.go

This file has not been changed.

+1 -7
appview/reporesolver/resolver.go
··· 85 85 86 86 stats := repo.RepoStats 87 87 if stats == nil { 88 - var starCount int 89 - var starErr error 90 - if repo.RepoDid != "" { 91 - starCount, starErr = db.GetStarCountByRepoDid(rr.execer, repo.RepoDid, repoAt) 92 - } else { 93 - starCount, starErr = db.GetStarCount(rr.execer, repoAt) 94 - } 88 + starCount, starErr := db.GetStarCount(rr.execer, repo.RepoDid, repoAt) 95 89 if starErr != nil { 96 90 log.Println("failed to get star count for ", repoAt) 97 91 }
appview/state/git_http.go

This file has not been changed.

appview/state/knotstream.go

This file has not been changed.

appview/state/router.go

This file has not been changed.

+2 -2
appview/state/star.go
··· 81 81 return 82 82 } 83 83 84 - starCount, err := db.GetStarCount(s.db, subjectUri) 84 + starCount, err := db.GetStarCount(s.db, "", subjectUri) 85 85 if err != nil { 86 86 log.Println("failed to get star count for ", subjectUri) 87 87 } ··· 120 120 // this is not an issue, the firehose event might have already done this 121 121 } 122 122 123 - starCount, err := db.GetStarCount(s.db, subjectUri) 123 + starCount, err := db.GetStarCount(s.db, "", subjectUri) 124 124 if err != nil { 125 125 log.Println("failed to get star count for ", subjectUri) 126 126 return
appview/state/state.go

This file has not been changed.

appview/validator/label.go

This file has not been changed.

History

14 rounds 2 comments
sign up or login to add to the discussion
1 commit
expand
appview: DID-based routing, state/handler/middleware updates
no conflicts, ready to merge
expand 0 comments
1 commit
expand
appview: DID-based routing, state/handler/middleware updates
expand 0 comments
1 commit
expand
appview: DID-based routing, state/handler/middleware updates
expand 2 comments

appview/state/state.go:631 won't this eventually redirect to /{owner}/{reponame}?

wdym by eventually? I was thinking to keep this in, so that we don't simply error out if someone does decide to be clever and link to their git repo by repoDID, we should render the page anyway to reward them for being clever instead of punishing heh

1 commit
expand
appview: DID-based routing, state/handler/middleware updates
expand 0 comments
1 commit
expand
appview: DID-based routing, state/handler/middleware updates
expand 0 comments
1 commit
expand
appview: update state, ingester, middleware, and resolver for repo DID
expand 0 comments
1 commit
expand
appview: update state, ingester, middleware, and resolver for repo DID
expand 0 comments
1 commit
expand
appview: update state, ingester, middleware, and resolver for repo DID
expand 0 comments
1 commit
expand
appview: update state, ingester, middleware, and resolver for repo DID
expand 0 comments
1 commit
expand
appview: update state, ingester, middleware, and resolver for repo DID
expand 0 comments
1 commit
expand
appview: update state, ingester, middleware, and resolver for repo DID
expand 0 comments
1 commit
expand
appview: update state, ingester, middleware, and resolver for repo DID
expand 0 comments
1 commit
expand
appview: update state, ingester, middleware, and resolver for repo DID
expand 0 comments
1 commit
expand
appview: update state, ingester, middleware, and resolver for repo DID
expand 0 comments