[feature] - Add copy-to-clipboard button for markdown code blocks · pull #1114

+9 -9

8 changed files

Interdiff #2 → #3

expand all

appview

pages

markup

extension

codecopy.go

tangledlink_test.go

markdown.go

markdown_test.go

reference_link.go

sanitizer.go

templates

layouts

base.html

input.css

appview/pages/markup/extension/codecopy.go

This file has not been changed.

+1 -1

appview/pages/markup/extension/tangledlink_test.go

··· 36 36 } 37 37 for _, tt := range tests { 38 38 t.Run(tt.name, func(t *testing.T) { 39 + md := markup.NewMarkdown("tangled.org") 39 - md := markup.NewMarkdown("tangled.org", nil) 40 40 41 41 var buf bytes.Buffer 42 42 if err := md.Convert([]byte(tt.markdown), &buf); err != nil {

+4 -3

appview/pages/markup/markdown.go

··· 53 53 Files fs.FS 54 54 } 55 55 56 - func NewMarkdown(hostname string, files fs.FS) goldmark.Markdown { 56 + func NewMarkdown(hostname string) goldmark.Markdown { 57 57 md := goldmark.New( 58 58 goldmark.WithExtensions( 59 59 extension.GFM, ··· 74 74 callout.CalloutExtention, 75 75 textension.AtExt, 76 76 textension.NewTangledLinkExt(hostname), 77 - textension.NewCodeCopyExt(files), 78 77 emoji.Emoji, 79 78 ), 80 79 goldmark.WithParserOptions( ··· 86 85 } 87 86 88 87 func (rctx *RenderContext) RenderMarkdown(source string) string { 89 - return rctx.RenderMarkdownWith(source, NewMarkdown(rctx.Hostname, rctx.Files)) 88 + md := NewMarkdown(rctx.Hostname) 89 + textension.NewCodeCopyExt(rctx.Files).Extend(md) 90 + return rctx.RenderMarkdownWith(source, md) 90 91 } 91 92 92 93 func (rctx *RenderContext) RenderMarkdownWith(source string, md goldmark.Markdown) string {

+3 -3

appview/pages/markup/markdown_test.go

··· 33 33 34 34 for _, tt := range tests { 35 35 t.Run(tt.name, func(t *testing.T) { 36 + md := NewMarkdown("tangled.org") 36 - md := NewMarkdown("tangled.org", nil) 37 37 38 38 var buf bytes.Buffer 39 39 if err := md.Convert([]byte(tt.markdown), &buf); err != nil { ··· 96 96 97 97 for _, tt := range tests { 98 98 t.Run(tt.name, func(t *testing.T) { 99 + md := NewMarkdown("tangled.org") 99 - md := NewMarkdown("tangled.org", nil) 100 100 101 101 var buf bytes.Buffer 102 102 if err := md.Convert([]byte(tt.markdown), &buf); err != nil { ··· 151 151 152 152 for _, tt := range tests { 153 153 t.Run(tt.name, func(t *testing.T) { 154 + md := NewMarkdown("tangled.org") 154 - md := NewMarkdown("tangled.org", nil) 155 155 156 156 var buf bytes.Buffer 157 157 if err := md.Convert([]byte(tt.markdown), &buf); err != nil {

+1 -1

appview/pages/markup/reference_link.go

··· 22 22 var ( 23 23 refLinkSet = make(map[models.ReferenceLink]struct{}) 24 24 mentionsSet = make(map[string]struct{}) 25 + md = NewMarkdown(host) 25 - md = NewMarkdown(host, nil) 26 26 sourceBytes = []byte(source) 27 27 root = md.Parser().Parse(text.NewReader(sourceBytes)) 28 28 )

appview/pages/markup/sanitizer.go

This file has not been changed.

appview/pages/templates/layouts/base.html

This file has not been changed.

-1

input.css

··· 1044 1044 .chroma .gl { 1045 1045 text-decoration: underline; 1046 1046 } 1047 - 1048 1047 } 1049 1048 1050 1049 actor-typeahead {

History

6 rounds 6 comments

natespilman.com submitted #5 6d

diff interdiff

1 commit

expand

b300c86b

appview/pages: add copy-to-clipboard button for markdown code blocks

no conflicts, ready to merge

expand 0 comments

natespilman.com submitted #4 15d

diff interdiff

1 commit

expand

2ccefe00

appview/pages: add copy-to-clipboard button for markdown code blocks

expand 3 comments

oppi.li 11d

works brilliantly! one nit: the copy button seems to add an extra newline for each line on my browser. do you notice the same behavior on your end?

will do a more thorough code review shortly!

natespilman.com 7d

I still need to look into this!! I asked Claude in the meantime, and it thinks you're right - there's an unnecessary carriage return

natespilman.com 6d

updated!

natespilman.com submitted #3 15d

diff

1 commit

expand

5663d756

appview/pages: add copy-to-clipboard button for markdown code blocks

expand 0 comments

natespilman.com submitted #2 15d

diff interdiff

1 commit

expand

63e62ad9

appview/pages: add copy-to-clipboard button for markdown code blocks

expand 0 comments

natespilman.com submitted #1 16d

diff interdiff

1 commit

expand

59b3e8ad

appview/pages: add copy-to-clipboard button for markdown code blocks

expand 3 comments

boltless.me 16d

Thank you for the contribution! Few feedbacks:

here we can use icon template like others.
can we use tailwindcss for styling? using @applysyntax in css file.

oppi.li 16d

i would prefer if we added this button using a goldmark extension instead of a clientside script!

natespilman.com 15d

Thank you for the feedback! I've updating the diff to use goldmark and apply tailwind classes.

natespilman.com submitted #0 16d

diff

1 commit

expand

64ceff0b

appview/pages: add copy-to-clipboard button for markdown code blocks

expand 0 comments

[feature] - Add copy-to-clipboard button for markdown code blocks #1114

Summary#

Test plan#

History