Monorepo for Tangled tangled.org

appview/pages: fix diff/interdiff buttons #1086

merged opened by oppi.li targeting master from op/uzolywszowrz

the buttons were not being hidden/shown correctly when varying the active-round or diff/interdiff pages.

Signed-off-by: oppiliappan me@oppi.li

Labels

None yet.

assignee

None yet.

Participants 1
AT URI
at://did:plc:qfpnj4og54vl56wngdriaxug/sh.tangled.repo.pull/3mfizwvop3w22
+2 -2
Diff #0
+2 -2
appview/pages/templates/repo/pulls/pull.html
··· 315 315 </a> 316 316 </span> 317 317 <div class="flex gap-2 items-center"> 318 - {{ if ne $root.ActiveRound $round }} 318 + {{ if or $root.IsInterdiff (ne $root.ActiveRound $round) }} 319 319 <a class="btn-flat flex items-center gap-2 no-underline hover:no-underline text-sm" 320 320 href="/{{ $root.RepoInfo.FullName }}/pulls/{{ $root.Pull.PullId }}/round/{{ $round }}?{{ safeUrl $root.DiffOpts.Encode }}#round-#{{ $round }}"> 321 321 {{ i "diff" "w-4 h-4" }} 322 322 diff 323 323 </a> 324 324 {{ end }} 325 - {{ if ne $idx 0 }} 325 + {{ if and (ne $idx 0) (or (not $root.IsInterdiff) (ne $root.ActiveRound $round)) }} 326 326 <a class="btn-flat flex items-center gap-2 no-underline hover:no-underline text-sm" 327 327 href="/{{ $root.RepoInfo.FullName }}/pulls/{{ $root.Pull.PullId }}/round/{{ $round }}/interdiff?{{ safeUrl $root.DiffOpts.Encode }}"> 328 328 {{ i "chevrons-left-right-ellipsis" "w-4 h-4 rotate-90" }}

History

1 round 0 comments
sign up or login to add to the discussion
oppi.li submitted #0
1 commit
expand
appview/pages: fix diff/interdiff buttons
3/3 success
expand
expand 0 comments
pull request successfully merged