tangled.org
We should resolve handle on render and we are already doing that. Removing the unused field.
Signed-off-by: Seongmin Lee git@boltless.me
+9
-15
Diff
round #1
-3
appview/oauth/accounts.go
-3
appview/oauth/accounts.go
···
13
13
14
14
type AccountInfo struct {
15
15
Did string `json:"did"`
16
-
Handle string `json:"handle"`
17
16
SessionId string `json:"session_id"`
18
17
AddedAt int64 `json:"added_at"`
19
18
}
···
74
73
for i, acc := range r.Accounts {
75
74
if acc.Did == did {
76
75
r.Accounts[i].SessionId = sessionId
77
-
r.Accounts[i].Handle = handle
78
76
return nil
79
77
}
80
78
}
···
85
83
86
84
r.Accounts = append(r.Accounts, AccountInfo{
87
85
Did: did,
88
-
Handle: handle,
89
86
SessionId: sessionId,
90
87
AddedAt: time.Now().Unix(),
91
88
})
+9
-12
appview/oauth/accounts_test.go
+9
-12
appview/oauth/accounts_test.go
···
28
28
{
29
29
name: "add second account",
30
30
initial: []AccountInfo{
31
-
{Did: "did:plc:abc123", Handle: "alice.bsky.social", SessionId: "session-1", AddedAt: 1000},
31
+
{Did: "did:plc:abc123", SessionId: "session-1", AddedAt: 1000},
32
32
},
33
33
addDid: "did:plc:def456",
34
34
addHandle: "bob.bsky.social",
···
40
40
{
41
41
name: "update existing account session",
42
42
initial: []AccountInfo{
43
-
{Did: "did:plc:abc123", Handle: "alice.bsky.social", SessionId: "old-session", AddedAt: 1000},
43
+
{Did: "did:plc:abc123", SessionId: "old-session", AddedAt: 1000},
44
44
},
45
45
addDid: "did:plc:abc123",
46
46
addHandle: "alice.bsky.social",
···
112
112
{
113
113
name: "remove existing account",
114
114
initial: []AccountInfo{
115
-
{Did: "did:plc:abc123", Handle: "alice", SessionId: "s1"},
116
-
{Did: "did:plc:def456", Handle: "bob", SessionId: "s2"},
115
+
{Did: "did:plc:abc123", SessionId: "s1"},
116
+
{Did: "did:plc:def456", SessionId: "s2"},
117
117
},
118
118
removeDid: "did:plc:abc123",
119
119
wantLen: 1,
···
122
122
{
123
123
name: "remove non-existing account",
124
124
initial: []AccountInfo{
125
-
{Did: "did:plc:abc123", Handle: "alice", SessionId: "s1"},
125
+
{Did: "did:plc:abc123", SessionId: "s1"},
126
126
},
127
127
removeDid: "did:plc:notfound",
128
128
wantLen: 1,
···
131
131
{
132
132
name: "remove last account",
133
133
initial: []AccountInfo{
134
-
{Did: "did:plc:abc123", Handle: "alice", SessionId: "s1"},
134
+
{Did: "did:plc:abc123", SessionId: "s1"},
135
135
},
136
136
removeDid: "did:plc:abc123",
137
137
wantLen: 0,
···
171
171
func TestAccountRegistry_FindAccount(t *testing.T) {
172
172
registry := &AccountRegistry{
173
173
Accounts: []AccountInfo{
174
-
{Did: "did:plc:first", Handle: "first", SessionId: "s1", AddedAt: 1000},
175
-
{Did: "did:plc:second", Handle: "second", SessionId: "s2", AddedAt: 2000},
176
-
{Did: "did:plc:third", Handle: "third", SessionId: "s3", AddedAt: 3000},
174
+
{Did: "did:plc:first", SessionId: "s1", AddedAt: 1000},
175
+
{Did: "did:plc:second", SessionId: "s2", AddedAt: 2000},
176
+
{Did: "did:plc:third", SessionId: "s3", AddedAt: 3000},
177
177
},
178
178
}
179
179
···
182
182
if found == nil {
183
183
t.Fatal("FindAccount() returned nil for existing account")
184
184
}
185
-
if found.Handle != "second" {
186
-
t.Errorf("FindAccount() handle = %s, want second", found.Handle)
187
-
}
188
185
if found.SessionId != "s2" {
189
186
t.Errorf("FindAccount() sessionId = %s, want s2", found.SessionId)
190
187
}
History
9 rounds
0 comments
boltless.me
submitted
#8
1 commit
expand
collapse
appview/oauth: remove
.Handle from oauth.AccountInfo
We should resolve handle on render and we are already doing that.
Removing the unused field.
Signed-off-by: Seongmin Lee <git@boltless.me>
2/3 timeout, 1/3 success
expand
collapse
no conflicts, ready to merge
expand 0 comments
boltless.me
submitted
#7
1 commit
expand
collapse
appview/oauth: remove
.Handle from oauth.AccountInfo
We should resolve handle on render and we are already doing that.
Removing the unused field.
Signed-off-by: Seongmin Lee <git@boltless.me>
2/3 failed, 1/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#6
1 commit
expand
collapse
appview/oauth: remove
.Handle from oauth.AccountInfo
We should resolve handle on render and we are already doing that.
Removing the unused field.
Signed-off-by: Seongmin Lee <git@boltless.me>
2/3 failed, 1/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#5
1 commit
expand
collapse
appview/oauth: remove
.Handle from oauth.AccountInfo
We should resolve handle on render and we are already doing that.
Removing the unused field.
Signed-off-by: Seongmin Lee <git@boltless.me>
2/3 timeout, 1/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#4
1 commit
expand
collapse
appview/oauth: remove
.Handle from oauth.AccountInfo
We should resolve handle on render and we are already doing that.
Removing the unused field.
Signed-off-by: Seongmin Lee <git@boltless.me>
2/3 failed, 1/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#3
1 commit
expand
collapse
appview/oauth: remove
.Handle from oauth.AccountInfo
We should resolve handle on render and we are already doing that.
Removing the unused field.
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#2
1 commit
expand
collapse
appview/oauth: remove
.Handle from oauth.AccountInfo
We should resolve handle on render and we are already doing that.
Removing the unused field.
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#1
1 commit
expand
collapse
appview/oauth: remove
.Handle from oauth.AccountInfo
We should resolve handle on render and we are already doing that.
Removing the unused field.
Signed-off-by: Seongmin Lee <git@boltless.me>
2/3 failed, 1/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#0
1 commit
expand
collapse
appview/oauth: remove
.Handle from oauth.AccountInfo
We should resolve handle on render and we are already doing that.
Removing the unused field.
Signed-off-by: Seongmin Lee <git@boltless.me>