tangled.org
We don't need to pass full MultiAccountUser here. just []AccountInfo
should be enough. This way, we can make MultiAccountUser to always
hold an active user.
Signed-off-by: Seongmin Lee git@boltless.me
appview/oauth/accounts.go
appview/oauth/accounts.go
This file has not been changed.
appview/oauth/accounts_test.go
appview/oauth/accounts_test.go
This file has not been changed.
+8
-8
appview/pages/pages.go
+8
-8
appview/pages/pages.go
···
248
248
}
249
249
250
250
type LoginParams struct {
251
-
ReturnUrl string
252
-
ErrorCode string
253
-
AddAccount bool
254
-
Accounts []oauth.AccountInfo
251
+
ReturnUrl string
252
+
ErrorCode string
253
+
AddAccount bool
254
+
LoggedInUser *oauth.MultiAccountUser
255
255
}
256
256
257
257
func (p *Pages) Login(w io.Writer, params LoginParams) error {
···
309
309
}
310
310
311
311
type LoginParams struct {
312
-
ReturnUrl string
313
-
ErrorCode string
314
-
AddAccount bool
315
-
LoggedInUser *oauth.MultiAccountUser
312
+
ReturnUrl string
313
+
ErrorCode string
314
+
AddAccount bool
315
+
Accounts []oauth.AccountInfo
316
316
}
317
317
318
318
func (p *Pages) Login(w io.Writer, params LoginParams) error {
appview/pages/templates/user/login.html
appview/pages/templates/user/login.html
This file has not been changed.
appview/pulls/pulls.go
appview/pulls/pulls.go
This file has not been changed.
appview/reporesolver/resolver.go
appview/reporesolver/resolver.go
This file has not been changed.
appview/state/login.go
appview/state/login.go
This patch was likely rebased, as context lines do not match.
appview/state/timeline.go
appview/state/timeline.go
This file has not been changed.
History
9 rounds
0 comments
boltless.me
submitted
#8
1 commit
expand
collapse
appview/{pages,state}: simplify LoginPage params
We don't need to pass full `MultiAccountUser` here. just `[]AccountInfo`
should be enough. This way, we can make `MultiAccountUser` to always
hold an active user.
Signed-off-by: Seongmin Lee <git@boltless.me>
2/3 timeout, 1/3 success
expand
collapse
no conflicts, ready to merge
expand 0 comments
boltless.me
submitted
#7
1 commit
expand
collapse
appview/{pages,state}: simplify LoginPage params
We don't need to pass full `MultiAccountUser` here. just `[]AccountInfo`
should be enough. This way, we can make `MultiAccountUser` to always
hold an active user.
Signed-off-by: Seongmin Lee <git@boltless.me>
2/3 failed, 1/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#6
1 commit
expand
collapse
appview/{pages,state}: simplify LoginPage params
We don't need to pass full `MultiAccountUser` here. just `[]AccountInfo`
should be enough. This way, we can make `MultiAccountUser` to always
hold an active user.
Signed-off-by: Seongmin Lee <git@boltless.me>
2/3 failed, 1/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#5
1 commit
expand
collapse
appview/{pages,state}: simplify LoginPage params
We don't need to pass full `MultiAccountUser` here. just `[]AccountInfo`
should be enough. This way, we can make `MultiAccountUser` to always
hold an active user.
Signed-off-by: Seongmin Lee <git@boltless.me>
2/3 failed, 1/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#4
1 commit
expand
collapse
appview/{pages,state}: simplify LoginPage params
We don't need to pass full `MultiAccountUser` here. just `[]AccountInfo`
should be enough. This way, we can make `MultiAccountUser` to always
hold an active user.
Signed-off-by: Seongmin Lee <git@boltless.me>
2/3 failed, 1/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#3
1 commit
expand
collapse
appview/{pages,state}: simplify LoginPage params
We don't need to pass full `MultiAccountUser` here. just `[]AccountInfo`
should be enough. This way, we can make `MultiAccountUser` to always
hold an active user.
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#2
1 commit
expand
collapse
appview/{pages,state}: simplify LoginPage params
We don't need to pass full `MultiAccountUser` here. just `[]AccountInfo`
should be enough. This way, we can make `MultiAccountUser` to always
hold an active user.
Signed-off-by: Seongmin Lee <git@boltless.me>
2/3 failed, 1/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#1
1 commit
expand
collapse
appview/{pages,state}: simplify LoginPage params
We don't need to pass full `MultiAccountUser` here. just `[]AccountInfo`
should be enough. This way, we can make `MultiAccountUser` to always
hold an active user.
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#0
1 commit
expand
collapse
appview/{pages,state}: simplify LoginPage params
We don't need to pass full `MultiAccountUser` here. just `[]AccountInfo`
should be enough. This way, we can make `MultiAccountUser` to always
hold an active user.
Signed-off-by: Seongmin Lee <git@boltless.me>