tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/{oauth,pages,state}: remove unused AddAccount session data #1020

open opened by boltless.me targeting master from sl/uvpzuszrulvq

idk why is this added. Seems like it isn't used?

Signed-off-by: Seongmin Lee git@boltless.me

STACK 11
#800 draft: appview: service layer
0/3
0
#19
#1027 appview: remove oauth.User type
1/3
0
#8
#1021 appview/pulls: remove dependencies to oauth.MultiAccountUser
3/3
0
#8
#1026 appview/pages: don't access MultiAccountUser.Active from template
1/3
0
#8
#1025 appview/oauth: remove .Handle from oauth.AccountInfo
1/3
0
#8
#1024 appview/oauth: remove AuthReturnInfo
1/3
0
#8
#1020 appview/{oauth,pages,state}: remove unused AddAccount session data
1/3
0
#8
#1023 appview/{pages,state}: simplify LoginPage params
1/3
0
#8
#1022 appview/{oauth,pages}: cleanup unused codes
1/3
0
#8
#1188 appview: don't trust oauth.ClientSessionData
1/3
0
#3
#1150 appview: use explicit TANGLED_PDS_HANDLE_SUFFIX for tngl.sh user check
1/3
1
#4
ABANDONED PULLS 2
#1149 appview: wip
2/3
0
#0
#1028 appview/{oauth,pages}: remove Pds field from oauth.User
2/3
0
#4
Labels

None yet.

assignee

None yet.

Participants 1
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3mdcq5ouzcc22
+1 -1
Interdiff #4 → #5
appview/oauth/accounts.go

This file has not been changed.

appview/oauth/consts.go

This file has not been changed.

appview/pages/templates/user/login.html

This file has not been changed.

appview/state/login.go

This patch was likely rebased, as context lines do not match.

+1 -1
appview/oauth/oauth.go
··· 396 396 info.AccountDID = &parsedDid 397 397 o.ClientApp.Store.SaveAuthRequestInfo(ctx, *info) 398 398 399 - if err := o.SetAuthReturn(w, r, returnURL, false); err != nil { 399 + if err := o.SetAuthReturn(w, r, returnURL); err != nil { 400 400 return "", fmt.Errorf("failed to set auth return: %w", err) 401 401 } 402 402

History

9 rounds 0 comments
sign up or login to add to the discussion
boltless.me submitted #8
diff interdiff
1 commit
expand
dd792f1c
appview/{oauth,pages,state}: remove unused AddAccount session data
2/3 timeout, 1/3 success
expand
build.yml
fmt.yml
test.yml
no conflicts, ready to merge
expand 0 comments
boltless.me submitted #7
diff interdiff
1 commit
expand
abd1167f
appview/{oauth,pages,state}: remove unused AddAccount session data
2/3 failed, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #6
diff interdiff
1 commit
expand
abd1167f
appview/{oauth,pages,state}: remove unused AddAccount session data
2/3 failed, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #5
diff
1 commit
expand
3c79932f
appview/{oauth,pages,state}: remove unused AddAccount session data
2/3 failed, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #4
diff interdiff
1 commit
expand
8d635ac4
appview/{oauth,pages,state}: remove unused AddAccount session data
2/3 failed, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #3
diff interdiff
1 commit
expand
55c5869d
appview/{oauth,pages,state}: remove unused AddAccount session data
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #2
diff interdiff
1 commit
expand
7eddbe6f
appview/{oauth,pages,state}: remove unused AddAccount session data
2/3 failed, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #1
diff interdiff
1 commit
expand
4183d864
appview/{oauth,pages,state}: remove unused AddAccount session data
1/3 failed, 2/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #0
diff
1 commit
expand
09f9fbbb
appview/{oauth,pages,state}: remove unused AddAccount session data
2/3 failed, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments