Monorepo for Tangled tangled.org

appview/state: support /favicon.ico #1015

open opened by boltless.me targeting master from sl/wznxxmtqvxwk

apps like pdsls.dev expects favicon to exist in well-known path

Signed-off-by: Seongmin Lee git@boltless.me

Labels

None yet.

assignee

None yet.

Participants 3
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3mda56w3xqo22
+3
Diff #1
+3
appview/state/router.go
··· 32 32 s.pages, 33 33 ) 34 34 35 + router.Get("/favicon.ico", func(w http.ResponseWriter, r *http.Request) { 36 + http.Redirect(w, r, "/static/logos/dolly.ico", http.StatusMovedPermanently) 37 + }) 35 38 router.Get("/pwa-manifest.json", s.WebAppManifest) 36 39 router.Get("/robots.txt", s.RobotsTxt) 37 40

History

2 rounds 5 comments
sign up or login to add to the discussion
1 commit
expand
appview/state: support /favicon.ico
3/3 success
expand
no conflicts, ready to merge
expand 4 comments

Does it have to be a redirect? Can鈥檛 we simply serve the same file here?

oh wait, it was using redirect too, my bad.

perhaps we should include favicon.svg as well!

1 commit
expand
appview/state: support /favicon.ico
1/3 failed, 2/3 success
expand
expand 1 comment

lgtm barring CI!