Cannot edit labels on a PR in Safari #583

Closed

heaths.dev 5mo ago

Closed opened by

heaths.dev 5mo ago

When I click the edit button (the pencil icon) in a PR to edit labels, it edits the assignee field instead. Clicking on the assignee edit button also edits he assignee. The <a> tag does seem correct:

<a hx-get="/<user>/<repo>/label/edit" hx-vals="{&quot;subject&quot;: &quot;at://<did>/sh.tangled.repo.pull/<TID>&quot;}" hx-swap="outerHTML" hx-target="#label-panel">

Safari version 26.5 (21624.2.5.11.4)

oppi.li 5mo ago

may seem counterintuitive, but this is what is happenning:

by default, the only labels available to put on a PR are the assignee: label.
the label panel allows editing all fields at once, so any edit button there open the full editor panel

i think the fix is to indicate that there are no labels configured, and add a link to settings here.

heaths.dev 5mo ago

Ah, I see that now. All but assignee just has the issue type. Being more clear about that sounds like a good idea.

oppi.li 3mo ago

should have nicer UX now!