Monorepo for Tangled tangled.org

PR diff view with 100+ commits #4780

Open boltless.me
Open opened by boltless.me

Currently API call limits to 100, but we can lazy-load more. Problem is interactive commit range selector UI. Pretty sure it won't work when there are a lot of commits. Even 50+ will be hard to manage.

Should we just drop the commit-range selector concept..? 🤔

we could have a "Show all" button like the repo overview and limit to, let's say, 25 commits/changes by default ?

screenshot of 'show all'

Yeah that's what I thought first, but what can user do after they expanded the 100+ commits? Now range selector become quite hard to use.

well they can select any of the commits they want to? we shouldn't take away that functionality from users. they can still shift-click to create a selection, drag, etc etc

I mean yeah, forget about shift-click because that's desktop-only and has no indicator about its existence. I think it would be pretty hard to drag around 100+ rows.

but mobile users aren't first-class unfortunately. development (in general) is very desktop-centric work.
i don't think we should worry that much about mobile users and such edge cases. i hear you that it'd be tough to drag 100+ rows around but that's our workflow.. and it's just not designed for mobile because that's not our focus

I will make hotfix with "Show all" style, but I think my point still stands. Even in desktop, I don't know about the existence of shift-key. keyboard shortcuts are usually for power users.

So let's take some time thinking how we can improve it from its current shape.

Sign up or Sign in to add to the discussion.