Monorepo for Tangled tangled.org

spindle: consider changing org.tangled.ci.subscribePipelineLogs#data.stream to open "enum" #4762

Open joshghiloni.me
Open opened by joshghiloni.me

Right now, the stream field on the org.tangled.ci.subscribePipelineLogs#data object must either be stdout or stderr. Some spindle implementations might find that onerous to stick to. I'm working on an implementation of a spindle that will schedule workflows inside k8s pods and getting separate logs isn't even an alpha feature until the latest version and requires activating a feature gate, which may not be possible in public-cloud managed offerings like EKS or GKE. If the enum were switched to a knownValues list and listed stdout, stderr, and combined, it would be much easier to implement in a way that is more idiomatically correct; otherwise I might just have to pick one.

Happy to contribute the fix as it's small, but wanted to have the conversation here first.

Thank you for the feedback!

In that case, I'd rather make #data.stream optional so it becomes "undefined" instead of explicit "combined". I think "combined" makes less sense when it can technically be mixed with stdout and stderr lines. Most clients will fallback to stdout style anyway.

Sign up or Sign in to add to the discussion.