tangled.org / core
Monorepo for Tangled tangled.org
fork atom

Pulls and issues pagination buttons have incorrectly escaped query parameters #386

open opened by rix.org

Steps to repro:

  1. Go to https://tangled.org/tangled.org/core/pulls?state=merged
  2. Click "next" button

Expected result: Should land on https://tangled.org/tangled.org/core/pulls?state=merged&q=&offset=30&limit=30

Actual result: Landed on https://tangled.org/tangled.org/core/pulls?state%3dmerged%26q%3d&offset=30&limit=30

The QueryParams was constructed with printf here: https://tangled.org/tangled.org/core/blob/2403bf5e0aba49b48e8384467b31ed84268196ae/appview/pages/templates/repo/pulls/pulls.html#L178

This returns a string type, and then passed to here: https://tangled.org/tangled.org/core/blob/2403bf5e0aba49b48e8384467b31ed84268196ae/appview/pages/templates/fragments/pagination.html#L88

Which will be escaped with urlescaper, and therefore state=merged&q= became state%3dmerged%26q%3d.

oppi.li

thanks, noticed this earlier today: https://tangled.org/tangled.org/core/pulls/1012 should be the fix.

sign up or login to add to the discussion
Labels

None yet.

area

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:msjibxgtuivrikhsdotgr5hq/sh.tangled.repo.issue/3mcytomhytq22