Monorepo for Tangled tangled.org

Remove @ in tangled URLs #245

closed
opened by xan.lol edited

Currently something like https://tangled.org/xan.lol/xan.lol redirects to https://tangled.org/@xan.lol/xan.lol, when it might make more sense for that to be the other way around! Some reasons:

  1. it doesn't look good (extremely subjective)
  2. adds an unnecessary extra character
  3. it probably wouldn't mess with anything else
  4. mismatch compared with other atproto apps (and also especially git forges)
  5. handles are already clear with the .

I’m on the cusp, but I reacted β€œπŸ‘Žβ€, as:

  • I quite like the β€œ@β€œ!
  • it clearly differentiates between user stuff, and site stuff; tangled.org/settings vs. tangled.org/@settings.in
    • (plus, check out GitHub’s URL oddities when you’re managing teams, you have to swap between /{org}/{repo} to /orgs/{org}/repos/{repo}/whatever; though they don’t have the benefit of definitely having a dot in any username)
  • it feels quite β€œATProto” to have an AT☺️
  • URL paths don’t really feature as part of the UI any more (they’re omitted in most browsers), so the value is in what it means to people creating URLs (developers), and we do love namespaces 😊

Plus I think I’d keep the @s in the UI anyway (eg. In the header of a repo page β€œ@tangled.org/core”) β€” so then the URLs would match what’s displayed.

(I think your point about mismatching with other forges is a crucial one; though these aren’t just usernames, they’re domains, so I think the difference is warranted)

I’d be happy either way though!

BTW if designed well removing @ won't conflict with special pages and usernames, like, in ATProto there's no one called "settings" or even "com" cause the handle rule permits, and that's what I thought.

Or @ can be kept because it can seperate Tangled's and users' from ATProto. So I just have NO IDEAS.

yes this is doable from an implementation standpoint: according to the atproto spec, all handles must include atleast one . so we can always differentiate between pages and users in routes.

i am voting in favor of this because of two things:

  • @foo.com is not a valid atproto handle, foo.com is a valid atproto handle. @ is simply a stylistic addition.
  • our SSH urls are git@knot.com:handle.com/repo-name, where @ is omitted. (we could update knot guard to accept both forms to be honest)

the SSH URL case in particular convinced me to be for this change

I also found these two reasons convincing enough to vote in favor of removal.

One small, silly side effect of this will be that the address for tangled itself will be tangled.org/tangled.org

if we named the core repo tangled.org, then to clone the source code, you will have to do git clone https://tangled.org/tangled.org/tangled.org!

I vote removing them. You can tell if it's a handle by the presence of the .s

i vote yes, i'm probably stupid but i dont think go modules like there being @s in the url so i just use github, i'm sure theres a way around it, but its best to minimize friction

For what it's worth, we've always supported the non-@ URL as well. We just redirect it to the @'d versionβ€”which Go seems to be content with.

[deleted by author]

So i'm a πŸ‘ I dig the poetry of having an @ in the URI, but mostly i think it's confusing. This isn't a practice the other Apps & AppServers use. It's also confusing because an AT:// URI is something distinct and different.

And just personally, it's a URL eyesore for me.

I voted for removal because I always reference my Tangled repositories on SSH with my DID instead.

implemented in https://tangled.org/@tangled.org/core/pulls/666, will be merged and deployed with the next release!

this has been released! all URLs (on the website, and in git clones etc.) will continue to accept @; they are simply redirected to the version without @.

Ξ» git clone https://tangled.org/@tangled.org/core.git x
Cloning into 'x'...
warning: redirecting to https://tangled.org/tangled.org/core.git/
.
.
.

This has tripped me up quite a few times on the SSH URLs with extraneous @s, so thank you for making this change!

sign up or login to add to the discussion
Labels

None yet.

area

None yet.

assignee

None yet.

Participants 12
+7
AT URI
at://did:plc:q7suwaz53ztc4mbiqyygbn43/sh.tangled.repo.issue/3m2bbgkmgun22