Fix references not being removed #173

Closed

targeting main from jack.is/sequoia:remove-all-footnotes

Closed opened by and assigned to

jack.is 5mo ago targeting main from jack.is/sequoia:remove-all-footnotes

fixes #40.

Commits 3

Merge branch 'remove-all-footnotes' of ssh://tangled.org/jack.is/sequoia into remove-all-footnotes

Fix references not being removed

+5 -5

Fix references not being removed

+2 -1

Comments

v0 5mo ago

Thanks for this @jack.is! Could you try rebasing? Had some other PRs go through

Could you add a test case? I added tests already for this and I imagine they'll be broken now since it checked that [^1] was actually left.

@stevedylan.dev could we have another workflow for running tests? As sequoia gets more attention, regression tests would be great to have.

@heaths.dev yeah I think that’s a good idea

I'm working on one now while I try to figure out what's going on with the lint workflow.

Can do re: tests.

sorry the tangled workflow is a little different than I'm used to and I think I still ended up with a merge conflict here :sad-panda:

Try:

git fetch origin main
git rebase FETCH_HEAD
bun lint
bun format

well I think I've fixed it, but tangled isn't letting me resubmit for round 3.

Not sure why tangled is misbehaving, just going to reopen a fresh one and hopefully fix the merge conflicts with it.

All good! I think I’ve had problems rebasing with tangled too