# SPDX-License-Identifier: AGPL-3.0-only # Copyright (c) 2026 sol pbc """Pytest fixture-leak detector. Captures `git status --porcelain -- tests/fixtures/` at session start and diffs at session end. Fails the session with a named-path error when tests leave the fixture tree dirty. """ from __future__ import annotations import os import subprocess import sys import tempfile from pathlib import Path import pytest _TMPDIR_FALLBACK_NOTICE: str | None = None def _apply_tmpdir_fallback() -> None: """Route tmp dirs to /var/tmp when TMPDIR is not exported. make test sets TMPDIR=/var/tmp at the shell level (see Makefile). Direct pytest invocations (.venv/bin/pytest, python -m pytest, uv run pytest) bypass that. This prelude closes the gap by setting TMPDIR and tempfile.tempdir at module-import time, before pytest builds its tmp_path_factory. """ global _TMPDIR_FALLBACK_NOTICE if "TMPDIR" in os.environ: return # Test-only override so unwritable-target branch can be exercised # without chmod 000 /var/tmp. target = os.environ.get("_SOLSTONE_TMPDIR_FALLBACK_TARGET", "/var/tmp") if not (os.path.isdir(target) and os.access(target, os.W_OK)): if os.environ.get("_SOLSTONE_TMPDIR_FALLBACK_NOTIFIED") != "1": _TMPDIR_FALLBACK_NOTICE = ( f"solstone: pytest invoked without TMPDIR export and fallback " f"target {target} is not writable; leaving TMPDIR unset.\n" ) os.environ["_SOLSTONE_TMPDIR_FALLBACK_NOTIFIED"] = "1" return os.environ["TMPDIR"] = target tempfile.tempdir = target if os.environ.get("_SOLSTONE_TMPDIR_FALLBACK_NOTIFIED") != "1": _TMPDIR_FALLBACK_NOTICE = ( f"solstone: pytest invoked without TMPDIR export; routing tmp dirs " f"to {target}. Prefer 'make test' to set TMPDIR at the shell level.\n" ) os.environ["_SOLSTONE_TMPDIR_FALLBACK_NOTIFIED"] = "1" _apply_tmpdir_fallback() _FIXTURE_ROOT = "tests/fixtures" _BASELINE: set[tuple[str, str]] | None = None _GIT_AVAILABLE = True def _capture_status(repo_root: Path) -> set[tuple[str, str]] | None: """Return the set of (status_XY, path) tuples from fixture-tree git status. Returns None when git is unavailable or the command fails (e.g. not a git repo). """ try: result = subprocess.run( ["git", "status", "--porcelain", "--", _FIXTURE_ROOT], cwd=repo_root, capture_output=True, text=True, check=False, ) except FileNotFoundError: return None if result.returncode != 0: return None entries: set[tuple[str, str]] = set() for line in result.stdout.splitlines(): if len(line) < 4: continue status = line[:2] path = line[3:] if " -> " in path: path = path.split(" -> ", 1)[1] entries.add((status, path)) return entries def _format_leak_message(new_entries: set[tuple[str, str]]) -> str: lines = [f" {status} {path}" for status, path in sorted(new_entries)] return ( "\n" "solstone fixture-leak detector: tests left tests/fixtures/ dirty\n" + "\n".join(lines) + "\n\n" "To fix, use one of these isolation mechanisms:\n" " - journal_copy fixture (tests/conftest.py:188) — copies tracked fixtures to tmp_path\n" " - point SOLSTONE_JOURNAL at a tmp_path directly\n" " - mock the subprocess/write path so code never touches tests/fixtures/\n" "\n" "Prior incidents: f6f382a6, 2996e072\n" ) def pytest_sessionstart(session): global _BASELINE, _GIT_AVAILABLE, _TMPDIR_FALLBACK_NOTICE if hasattr(session.config, "workerinput"): return if _TMPDIR_FALLBACK_NOTICE is not None: sys.stderr.write(_TMPDIR_FALLBACK_NOTICE) _TMPDIR_FALLBACK_NOTICE = None repo_root = session.config.rootpath _BASELINE = _capture_status(repo_root) if _BASELINE is None: _GIT_AVAILABLE = False sys.stderr.write("solstone fixture-leak detector: git unavailable, skipping\n") def pytest_sessionfinish(session, exitstatus): if hasattr(session.config, "workerinput"): return if not _GIT_AVAILABLE or _BASELINE is None: return repo_root = session.config.rootpath current = _capture_status(repo_root) if current is None: return new_entries = current - _BASELINE if not new_entries: return sys.stderr.write(_format_leak_message(new_entries)) session.exitstatus = 1 @pytest.fixture(autouse=True) def _reset_local_slot_sizing_state(): """Keep per-process local sizing and admission state from leaking across tests.""" def _reset() -> None: admission = sys.modules.get("solstone.think.admission") if admission is not None: admission.reset_admission_state() local_server = sys.modules.get("solstone.think.providers.local_server") if local_server is not None: local_server.reset_parallel_slots_cache() fanout_policy = sys.modules.get("solstone.think.providers.fanout_policy") if fanout_policy is not None: fanout_policy.reset_default_cap_log_state() thinking = sys.modules.get("solstone.think.thinking") if thinking is not None: thinking.reset_dispatch_admission_state() _reset() yield _reset() @pytest.fixture(autouse=True) def _default_local_vulkan_gpu(): """Keep local-provider readiness deterministic on GPU-less test hosts.""" from solstone.think.providers import local_vulkan original_detect_gpus = local_vulkan.detect_gpus local_vulkan.reset_detect_cache() def fake_detect_gpus(): return [ local_vulkan.VulkanDevice( 1, "NVIDIA GeForce GTX 1660 Ti", local_vulkan.VK_TYPE_DISCRETE, 6390, ) ] local_vulkan.detect_gpus = fake_detect_gpus yield local_vulkan.detect_gpus = original_detect_gpus local_vulkan.reset_detect_cache()